Bug 535607 (RHQ-2285) - don't sendResourcError everytime getAvailability throws exception
Summary: don't sendResourcError everytime getAvailability throws exception
Keywords:
Status: CLOSED NOTABUG
Alias: RHQ-2285
Product: RHQ Project
Classification: Other
Component: Plugin Container
Version: unspecified
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: ---
Assignee: RHQ Project Maintainer
QA Contact:
URL: http://jira.rhq-project.org/browse/RH...
Whiteboard:
Depends On:
Blocks: rhq_triage
TreeView+ depends on / blocked
 
Reported: 2009-07-31 21:03 UTC by John Mazzitelli
Modified: 2011-03-15 04:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-15 04:56:10 UTC
Embargoed:


Attachments (Terms of Use)

Description John Mazzitelli 2009-07-31 21:03:00 UTC
see AvailabilityExecutor - don't always sendResourceError in the catch


                    if (resourceContainer.getResourceComponentState() == ResourceComponentState.STARTED) {
                        current = resourceComponent.getAvailability();
                    } else {
                        this.inventoryManager.activateResource(resource, resourceContainer, false);
                        if (resourceContainer.getResourceComponentState() == ResourceComponentState.STARTED) {
                            current = resourceComponent.getAvailability();
                        }
                    }
                } catch (Throwable t) {
                    ResourceError resourceError = new ResourceError(resource, ResourceErrorType.AVAILABILITY_CHECK, t,
                        System.currentTimeMillis());
                    this.inventoryManager.sendResourceErrorToServer(resourceError);
                    // TODO GH: Put errors in report, rather than sending them to the Server separately.
                    if (log.isDebugEnabled()) {
                        if (t instanceof TimeoutException)
                            // no need to log the stack trace for timeouts...
                            log.debug("Failed to collect availability on resource " + resource + " (call timed out)");
                        else
                            log.debug("Failed to collect availability on resource " + resource, t);
                    }
                }


Comment 1 John Mazzitelli 2009-08-09 20:10:50 UTC
ghinkle checked in svn rev 4810 that makes the sendResourceError NOT guaranteed - so it won't be sent again if it fails

Comment 2 Red Hat Bugzilla 2009-11-10 21:01:29 UTC
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-2285


Comment 3 wes hayutin 2010-02-16 16:54:52 UTC
Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs.

keyword:
new = Tracking + FutureFeature + SubBug

Comment 4 wes hayutin 2010-02-16 17:00:09 UTC
making sure we're not missing any bugs in rhq_triage

Comment 5 Joseph Marques 2010-11-17 17:22:42 UTC
Do we even want to support this type of ResourceError going forward?  I may be wrong, but I don't recall ever seeing this type of information in the server anywhere - we just show the latest AvailabilityType and availability history instead for each resource.  The only type of ResourceError we actually propagate to the UI is the one for plugin configuration errors.  In the last few weeks, we now support resource upgrade error types as well.  Unless there is a good reason to keep this kind of error, and unless we actually want to show that error somewhere in the UI (and does that mean that the message should be guaranteed?), then I vote to get rid of it.  Mazz, thoughts?

Comment 6 John Mazzitelli 2010-11-22 20:09:09 UTC
we can get rid of this

Comment 7 John Mazzitelli 2011-03-15 04:56:10 UTC
we actually do show this in the new GWT interface now.

this isn't a problem anymore. one final glitch is being fixed via BZ 664126. but now we can show issues with avail resource errors.


Note You need to log in before you can comment on or make changes to this bug.