Bug 538326
| Summary: | Review Request: perl-LWP-Online - Module for accessing web by proccess | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-20 07:40:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 538363 | ||
|
Description
Marcela Mašláňová
2009-11-18 09:43:31 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1813700 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) f1391f2b17d2e18b1c1396fb58a52cdf7efe40ec LWP-Online-1.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=3, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.23 cusr 0.03 csys = 0.30 CPU) + Package perl-LWP-Online-1.07-1.fc13.noarch => Provides: perl(LWP::Online) = 1.07 Requires: perl >= 0:5.005 perl(Carp) perl(LWP::Simple) perl(strict) perl(vars) + Not a GUI application Suggestions: 1) please remove following Requires as I see they are auto pulled by yum Requires: perl(LWP::Simple) Requires: perl(URI) APPROVED. New Package CVS Request ======================= Package Name: perl-LWP-Online Short Description: Module for accessing web by proccess Owners: mmaslano Branches: devel InitialCC: perl-sig CVS done. |