Bug 538363 - Review Request: perl-pip - Perl Installation Program
Summary: Review Request: perl-pip - Perl Installation Program
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Petr Lautrbach
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 538326 538360
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-18 11:49 UTC by Marcela Mašláňová
Modified: 2010-01-14 07:06 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-14 07:06:03 UTC
Type: ---
Embargoed:
plautrba: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Marcela Mašláňová 2009-11-18 11:49:39 UTC
Spec URL: http://mmaslano.fedorapeople.org/review/perl-pip.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-pip-0.13-1.fc12.src.rpm
Description: 
The pip ("Perl Installation Program") console application is used to
install Perl distributions in a wide variety of formats, both from CPAN and
from external third-party locations, while supporting module dependencies
that go across the boundary from third-party to CPAN.

Comment 1 Petr Lautrbach 2010-01-12 15:16:37 UTC
Hi, 

please fix or explain following FAILs.

*rpmlint FAIL
pip.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

pip package containts only /usr/bin/pip. Why this subpackage split? 

*sources FAIL
Actual upstream version is http://www.cpan.org/authors/id/A/AD/ADAMK/pip-1.16.tar.gz, please update your package.

*files, dirs now owned by other package FAIL
Directory /usr/share/perl5/Module is already owned by perl package

*naming OK
*spec filename OK
*license OK
*license in doc OK
*American EnglishOK
*legible OK 
*build OK
*buildrequires OK
*locales OK
*shared library OK
*system libraries OK
*not relocatable
*owns created directories OK
*files list once OK
*permissions OK
*defattr OK
*clean OK
*macros OK
*content OK
*doc OK
*headers OK
*static libs OK
*pkgconfig OK
*-devel  OK
*no .la files OK
*.desktop for GUI OK
*install with clean buildroot OK
*UTF8 OK
*license text included OK
*mock build OK
*all architectures OK
*fully versioned dependency OK

Comment 2 Marcela Mašláňová 2010-01-12 16:13:56 UTC
(In reply to comment #1)
> Hi, 
Hello,
> 
> please fix or explain following FAILs.
> 
> *rpmlint FAIL
> pip.noarch: W: no-documentation
> The package contains no documentation (README, doc, etc). You have to include
> documentation files.
> 
fixed
> pip package containts only /usr/bin/pip. Why this subpackage split? 
> 
removed
> *sources FAIL
> Actual upstream version is
> http://www.cpan.org/authors/id/A/AD/ADAMK/pip-1.16.tar.gz, please update your
> package.
> 
> *files, dirs now owned by other package FAIL
> Directory /usr/share/perl5/Module is already owned by perl package
That's ok (see https://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership)

New links:
http://mmaslano.fedorapeople.org/review/perl-pip-1.16-1.fc13.src.rpm
http://mmaslano.fedorapeople.org/review/perl-pip.spec

Comment 3 Petr Lautrbach 2010-01-13 09:36:42 UTC
> > 
> > *files, dirs now owned by other package FAIL
> > Directory /usr/share/perl5/Module is already owned by perl package
> That's ok (see
> https://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership)

Though I don't think that it's the same case, I can live with that. 

ACCEPT

Comment 4 Marcela Mašláňová 2010-01-13 09:52:28 UTC
New Package CVS Request
=======================
Package Name: perl-pip
Short Description: Perl Installation Program
Owners: mmaslano
Branches: devel
InitialCC: perl-sig

Comment 5 Jason Tibbitts 2010-01-13 20:37:17 UTC
CVS done (by process-cvs-requests.py).


Note You need to log in before you can comment on or make changes to this bug.