Bug 538360
| Summary: | Review Request: perl-CPAN-Inject - Base class for injecting distributions into CPAN sources | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-05 07:49:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 538361 | ||
| Bug Blocks: | 538363 | ||
|
Description
Marcela Mašláňová
2009-11-18 11:31:38 UTC
looks make test failed. see http://koji.fedoraproject.org/koji/taskinfo?taskID=1863802 Fixed: http://mmaslano.fedorapeople.org/review/perl-CPAN-Inject-0.11-2.fc12.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1886066 It is really confusing here as srpm download link is not working Anyway I just looked into fedorapeople page and got new updated srpm. Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1894218 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 41ff95c0c8dd1852645a8a3a063b039960a11141 CPAN-Inject-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=24, 4 wallclock secs ( 0.06 usr 0.01 sys + 0.64 cusr 0.06 csys = 0.77 CPU) + Package perl-CPAN-Inject-0.11-2.fc13.noarch=> Provides: perl(CPAN::Inject) = 0.11 Requires: /usr/bin/perl perl >= 0:5.005 perl(CPAN::Checksums) perl(CPAN::Inject) perl(File::Basename) perl(File::Copy) perl(File::Path) perl(File::Spec) perl(File::chmod) perl(File::stat) perl(Params::Util) perl(strict) perl(vars) + Not a GUI application Suggestions: 1) Please remove unnecessary Requires: from spec file. APPROVED. New Package CVS Request ======================= Package Name: perl-CPAN-Inject Short Description: Base class for injecting distributions into CPAN sources Owners: mmaslano InitialCC: perl-sig cvs done. |