Bug 540791
| Summary: | Review Request: rubygem-RubyInline - Write foreign code within your ruby code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Kent <mkent> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 3.8.3-4.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-28 14:34:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 539442 | ||
| Bug Blocks: | 541807 | ||
|
Description
Matthew Kent
2009-11-24 06:11:24 UTC
Spec URL: http://magoazul.com/wip/SPECS/rubygem-RubyInline.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-RubyInline-3.8.3-2.fc13.src.rpm * Mon Nov 23 2009 Matthew Kent <mkent> - 3.8.3-2 - Remove unused ruby_sitelib macro Some notes:
* BuildRequires
- "BR: gcc" is redundant because gcc is always installed
with mockbuild:
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
( Well, I can guess why you added such explicit "BR: gcc" because
actually "rake check" calls gcc while the rebuilt rpm itself
is noarch, however still I think "BR: gcc" is redundant )
! example scripts
-------------------------------------------------------
# Organize this in a more typical way
mkdir %{buildroot}%{geminstdir}/examples
mv %{buildroot}%{geminstdir}/*.rb %{buildroot}%{geminstdir}/examples/
-------------------------------------------------------
- I don't object to this, however I am not sure this is
really needed or not, as
* these scripts are packaged into -doc subpackage so people
will easily find that these scripts are examples or so.
* Also $ gem contents --prefix RubyInline expects that these
scripts are under %geminstdir.
This is NOT a blocker, because we already delete or move files
which are expected by $ gem contents, however for this
case I don't strictly feel the necessity for moving these
files.
However again I don't object to this.
Anyway no blockers.
---------------------------------------------------------------
This package (rubygem-RubyInline) is APPROVED by mtasaka
---------------------------------------------------------------
Thank you for the review. (In reply to comment #2) > Some notes: > > * BuildRequires > - "BR: gcc" is redundant because gcc is always installed > with mockbuild: > https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > ( Well, I can guess why you added such explicit "BR: gcc" because > actually "rake check" calls gcc while the rebuilt rpm itself > is noarch, however still I think "BR: gcc" is redundant ) > Noted, thank you for the link. > ! example scripts > ------------------------------------------------------- > # Organize this in a more typical way > mkdir %{buildroot}%{geminstdir}/examples > mv %{buildroot}%{geminstdir}/*.rb %{buildroot}%{geminstdir}/examples/ > ------------------------------------------------------- > - I don't object to this, however I am not sure this is > really needed or not, as > * these scripts are packaged into -doc subpackage so people > will easily find that these scripts are examples or so. > * Also $ gem contents --prefix RubyInline expects that these > scripts are under %geminstdir. > This is NOT a blocker, because we already delete or move files > which are expected by $ gem contents, however for this > case I don't strictly feel the necessity for moving these > files. > > However again I don't object to this. You're right - I should leave this up to the upstream developers. Spec URL: http://magoazul.com/wip/SPECS/rubygem-RubyInline.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-RubyInline-3.8.3-3.fc13.src.rpm * Thu Nov 26 2009 Matthew Kent <mkent> - 3.8.3-3 - Drop redundant BR for gcc (#540791) - Leave examples as upstream intended (#540791) New Package CVS Request ======================= Package Name: rubygem-RubyInline Short Description: Write foreign code within your ruby code Owners: mkent Branches: F-11 F-12 InitialCC: cvs done. rubygem-RubyInline-3.8.3-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-RubyInline-3.8.3-4.fc12 rubygem-RubyInline-3.8.3-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-RubyInline-3.8.3-4.fc11 Closing. rubygem-RubyInline-3.8.3-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-RubyInline-3.8.3-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-RubyInline New Branches: el5 el6 Owners: stahnma mkent is aware of change. Git done (by process-git-requests). |