Bug 541807 - Review Request: rubygem-ParseTree - Extracts the parse tree for a class/method and returns an s-expression
Summary: Review Request: rubygem-ParseTree - Extracts the parse tree for a class/metho...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 540791 541185 541512
Blocks: 542559
TreeView+ depends on / blocked
 
Reported: 2009-11-27 05:19 UTC by Matthew Kent
Modified: 2010-09-10 18:40 UTC (History)
3 users (show)

Fixed In Version: 3.0.4-4.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-08 07:59:06 UTC
Type: ---
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Matthew Kent 2009-11-27 05:19:01 UTC
Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-1.fc13.src.rpm
Description: ParseTree is a C extension (using RubyInline) that extracts the parse tree for an entire class or a specific method and returns it as a s-expression (aka sexp) using ruby's arrays, strings, symbols, and integers.

mkent@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint rubygem-ParseTree.spec /var/tmp/results/rubygem-ParseTree-*
rubygem-ParseTree-doc.noarch: W: no-documentation
rubygem-ParseTree-doc.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/.autotest
rubygem-ParseTree-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/ParseTree-3.0.4/ri/ParseTreeGauntlet/should_skip%3f-i.yaml %3f
3 packages and 1 specfiles checked; 0 errors, 3 warnings

Comment 1 Matthew Kent 2009-11-30 06:55:57 UTC
Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-2.fc13.src.rpm

* Sun Nov 29 2009 Matthew Kent <mkent@magoazul.com> - 3.0.4-2
- Exclude gauntlet_rubyparser.rb as it introduces a circular dependency.

Comment 2 Matthew Kent 2009-11-30 09:33:20 UTC
Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-3.fc13.src.rpm

* Mon Nov 30 2009 Matthew Kent <mkent@magoazul.com> - 3.0.4-3
- Remove exclude for gauntlet_parsetree.rb, let user deal with dependencies if
  they need it.

Comment 3 Mamoru TASAKA 2009-12-02 18:16:19 UTC
Some notes:

* Version specific dependency
  - I don't think ">= 3.7.0" ">= 3.0.0" is needed (as all rpms shipped
    on Fedora satisfies this dependency)
    ref:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

! demo
  - I tried demo program, then:
-------------------------------------------------------------------
[tasaka1@localhost ~]$ /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb
/usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb:20: uninitialized constant ParseTree (NameError)
-------------------------------------------------------------------
    I don't know well the usefulness of this script, however
    at least "require 'parse_tree'" is missing.

Comment 4 Matthew Kent 2009-12-04 06:06:31 UTC
Thank you for the review.

(In reply to comment #3)
> Some notes:
> 
> * Version specific dependency
>   - I don't think ">= 3.7.0" ">= 3.0.0" is needed (as all rpms shipped
>     on Fedora satisfies this dependency)
>     ref:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
> 

Apologies, should have caught this.

> ! demo
>   - I tried demo program, then:
> -------------------------------------------------------------------
> [tasaka1@localhost ~]$
> /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb
> /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb:20: uninitialized
> constant ParseTree (NameError)
> -------------------------------------------------------------------
>     I don't know well the usefulness of this script, however
>     at least "require 'parse_tree'" is missing.  

Yeah certainly doesn't look finished or useful at the moment, I'll exclude it with a note.

Comment 5 Matthew Kent 2009-12-04 06:07:11 UTC
Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-4.fc13.src.rpm

* Thu Dec 3 2009 Matthew Kent <mkent@magoazul.com> - 3.0.4-4
- Drop needless versions from Requires (#541807).
- Exclude demo/ for now as it's non functional (#541807).

Comment 6 Mamoru TASAKA 2009-12-05 18:43:12 UTC
Okay.

------------------------------------------------------------
  This package (rubygem-ParseTree) is APPROVED by mtasaka
------------------------------------------------------------

Comment 7 Matthew Kent 2009-12-05 19:08:00 UTC
New Package CVS Request
=======================
Package Name: rubygem-ParseTree
Short Description: Extracts the parse tree for a class/method and returns an s-expression
Owners: mkent
Branches: F-11 F-12
InitialCC:

Comment 8 Kevin Fenzi 2009-12-06 23:24:41 UTC
cvs done.

Comment 9 Fedora Update System 2009-12-08 05:13:52 UTC
rubygem-ParseTree-3.0.4-4.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/rubygem-ParseTree-3.0.4-4.fc11

Comment 10 Fedora Update System 2009-12-08 05:14:23 UTC
rubygem-ParseTree-3.0.4-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-ParseTree-3.0.4-4.fc12

Comment 11 Mamoru TASAKA 2009-12-08 07:59:06 UTC
Closing.

Comment 12 Fedora Update System 2009-12-10 04:23:28 UTC
rubygem-ParseTree-3.0.4-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2009-12-10 04:29:38 UTC
rubygem-ParseTree-3.0.4-4.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Michael Stahnke 2010-09-10 18:33:22 UTC
Package Change Request
======================
Package Name: rubygem-ParseTree
New Branches: el5 el6
Owners: stahnma

Comment 15 Kevin Fenzi 2010-09-10 18:40:32 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.