Bug 541694
| Summary: | Review Request: php-phpunit-File-Iterator - FilterIterator implementation that filters files based on a list of suffixes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christof Damian <christof> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, guillaume, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.1.0-4.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-04 23:56:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christof Damian
2009-11-26 18:34:02 UTC
This is a dependency for a new version of php-phpunit-phploc rpmlint output: php-phpunit-File-Iterator.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Spec URL: http://rpms.damian.net/SPECS/php-phpunit-File-Iterator.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpunit-File-Iterator-1.1.0-2.fc12.src.rpm rpmlint output: php-phpunit-File-Iterator.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. updated files to allow older pear versions, also replaced some command with macros > BuildRequires: php-pear >= 1.7.2
This is not correct because we have php-pear-4.3.9 in EL4
Shoud be
BuildRequires: php-pear >= 1:1.7.2
or
BuildRequires: php-pear(PEAR) >= 1.7.2
+
Please also requires php-common rather than php to avoid dependecy on httpd + (In reply to comment #3) > > BuildRequires: php-pear >= 1.7.2 > > This is not correct because we have php-pear-4.3.9 in EL4 > > Shoud be > BuildRequires: php-pear >= 1:1.7.2 > or > BuildRequires: php-pear(PEAR) >= 1.7.2 (In reply to comment #4) > Please also requires php-common rather than php to avoid dependecy on httpd I fixed both of these. New files: Spec URL: http://rpms.damian.net/SPECS/php-phpunit-File-Iterator.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpunit-File-Iterator-1.1.0-3.fc12.src.rpm REVIEW: + rpmlint is ok php-phpunit-File-Iterator.src: I: checking php-phpunit-File-Iterator.noarch: I: checking php-phpunit-File-Iterator.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources + sources match the upstream sources 8bd52abf03f3c8f86d296b4ee5d3d39d File_Iterator-1.1.0.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear >= 1:1.7.2, php-channel(pear.phpunit.de)) ok + no locale + no .so - DONT own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji (dist-f13) http://koji.fedoraproject.org/koji/taskinfo?taskID=1835237 + no test suite + scriptlets ok + Final Requires ok /usr/bin/pear php-channel(pear.phpunit.de) php-common >= 5.2.0 + Final Provides ok php-pear(pear.phpunit.de/File_Iterator) = 1.1.0 php-phpunit-File-Iterator = 1.1.0-3.fc8 Changing minimal dependency for PEAR seems acceptable as it's only for "installer" MUST fix: - own /usr/share/pear/File (In reply to comment #6) > > MUST fix: > - own /usr/share/pear/File I changed it to own all files and directories including and below /usr/share/pear/File Spec URL: http://rpms.damian.net/SPECS/php-phpunit-File-Iterator.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpunit-File-Iterator-1.1.0-4.fc12.src.rpm All must fixed ***** APPROVED ***** New Package CVS Request ======================= Package Name: php-phpunit-File-Iterator Short Description: FilterIterator implementation that filters files based on a list of suffixes Owners: cdamian Branches: F-11 F-12 EL-5 InitialCC: cvs done. php-phpunit-File-Iterator-1.1.0-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-phpunit-File-Iterator-1.1.0-4.fc12 php-phpunit-File-Iterator-1.1.0-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |