Bug 541807
Summary: | Review Request: rubygem-ParseTree - Extracts the parse tree for a class/method and returns an s-expression | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthew Kent <mkent> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mastahnke, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 3.0.4-4.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-12-08 07:59:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 540791, 541185, 541512 | ||
Bug Blocks: | 542559 |
Description
Matthew Kent
2009-11-27 05:19:01 UTC
Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-2.fc13.src.rpm * Sun Nov 29 2009 Matthew Kent <mkent> - 3.0.4-2 - Exclude gauntlet_rubyparser.rb as it introduces a circular dependency. Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-3.fc13.src.rpm * Mon Nov 30 2009 Matthew Kent <mkent> - 3.0.4-3 - Remove exclude for gauntlet_parsetree.rb, let user deal with dependencies if they need it. Some notes: * Version specific dependency - I don't think ">= 3.7.0" ">= 3.0.0" is needed (as all rpms shipped on Fedora satisfies this dependency) ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires ! demo - I tried demo program, then: ------------------------------------------------------------------- [tasaka1@localhost ~]$ /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb:20: uninitialized constant ParseTree (NameError) ------------------------------------------------------------------- I don't know well the usefulness of this script, however at least "require 'parse_tree'" is missing. Thank you for the review. (In reply to comment #3) > Some notes: > > * Version specific dependency > - I don't think ">= 3.7.0" ">= 3.0.0" is needed (as all rpms shipped > on Fedora satisfies this dependency) > ref: > https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires > Apologies, should have caught this. > ! demo > - I tried demo program, then: > ------------------------------------------------------------------- > [tasaka1@localhost ~]$ > /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb > /usr/lib/ruby/gems/1.8/gems/ParseTree-3.0.4/demo/printer.rb:20: uninitialized > constant ParseTree (NameError) > ------------------------------------------------------------------- > I don't know well the usefulness of this script, however > at least "require 'parse_tree'" is missing. Yeah certainly doesn't look finished or useful at the moment, I'll exclude it with a note. Spec URL: http://magoazul.com/wip/SPECS/rubygem-ParseTree.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ParseTree-3.0.4-4.fc13.src.rpm * Thu Dec 3 2009 Matthew Kent <mkent> - 3.0.4-4 - Drop needless versions from Requires (#541807). - Exclude demo/ for now as it's non functional (#541807). Okay. ------------------------------------------------------------ This package (rubygem-ParseTree) is APPROVED by mtasaka ------------------------------------------------------------ New Package CVS Request ======================= Package Name: rubygem-ParseTree Short Description: Extracts the parse tree for a class/method and returns an s-expression Owners: mkent Branches: F-11 F-12 InitialCC: cvs done. rubygem-ParseTree-3.0.4-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-ParseTree-3.0.4-4.fc11 rubygem-ParseTree-3.0.4-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-ParseTree-3.0.4-4.fc12 Closing. rubygem-ParseTree-3.0.4-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-ParseTree-3.0.4-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-ParseTree New Branches: el5 el6 Owners: stahnma Git done (by process-git-requests). |