Bug 541901

Summary: news.daily doesn't test or existence of innfeed lock files before cat'ing them
Product: [Fedora] Fedora Reporter: Need Real Name <bugzilla>
Component: innAssignee: Nikola Pajkovsky <npajkovs>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: dhoward, npajkovs, ovasik
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.5.0-6.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-01 04:16:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Need Real Name 2009-11-27 14:14:13 UTC 
Description of problem:

If you are running innd but don't have an infeed running then you presumably won't have any lock files in var/spool/news/innfeed.

However news.daily has the following lines:

    cd "${PATHSPOOL}/${INNFEEDSPOOL}"

    # Find the PIDs of innfeed.
    LOCKS=`cat *.lock | ${SORT} -u`

This attempt to 'cat' non-existent files leads to the following daily error message in the email sent out by the daily cron process inn-cron-expire:
    cat: *.lock: No such file or directory

This message is annoying, unnecessary, and confusing.

The code should be changed to either check for the presence of lock files first or at least to send the stderr to /dev/null.

For example:

LOCKS=`cat *.lock 2>/dev/null | ${SORT} -u`

Simple problem.... simple fix
Comment 1 Fedora Update System 2009-11-30 09:56:14 UTC 
inn-2.5.0-6.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/inn-2.5.0-6.fc12
Comment 2 Fedora Update System 2009-12-01 04:16:09 UTC 
inn-2.5.0-6.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.