Bug 541901 - news.daily doesn't test or existence of innfeed lock files before cat'ing them
Summary: news.daily doesn't test or existence of innfeed lock files before cat'ing them
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: inn
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nikola Pajkovsky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-27 14:14 UTC by Need Real Name
Modified: 2014-02-02 22:13 UTC (History)
3 users (show)

Fixed In Version: 2.5.0-6.fc12
Clone Of:
Environment:
Last Closed: 2009-12-01 04:16:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Need Real Name 2009-11-27 14:14:13 UTC
Description of problem:

If you are running innd but don't have an infeed running then you presumably won't have any lock files in var/spool/news/innfeed.

However news.daily has the following lines:

    cd "${PATHSPOOL}/${INNFEEDSPOOL}"

    # Find the PIDs of innfeed.
    LOCKS=`cat *.lock | ${SORT} -u`

This attempt to 'cat' non-existent files leads to the following daily error message in the email sent out by the daily cron process inn-cron-expire:
    cat: *.lock: No such file or directory

This message is annoying, unnecessary, and confusing.

The code should be changed to either check for the presence of lock files first or at least to send the stderr to /dev/null.

For example:

LOCKS=`cat *.lock 2>/dev/null | ${SORT} -u`

Simple problem.... simple fix

Comment 1 Fedora Update System 2009-11-30 09:56:14 UTC
inn-2.5.0-6.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/inn-2.5.0-6.fc12

Comment 2 Fedora Update System 2009-12-01 04:16:09 UTC
inn-2.5.0-6.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.