Bug 542027
Summary: | Review Request: php-nusoap - SOAP toolkit for PHP | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Nalley <david> |
Component: | Package Review | Assignee: | Gianluca Sforna <giallu> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, giallu, notting |
Target Milestone: | --- | Flags: | giallu:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.7.3-2.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-12-11 18:16:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 544722, 544724 |
Description
David Nalley
2009-11-28 00:22:03 UTC
I'll review this, one of my packages also bundles this lib spec looks good, for more legibility I'd add some blank lines before %prep, %build and %install. One important thing though. I checked the license in nusoap.php and the correct one looks like LGPLv2+ http://nusoap.cvs.sourceforge.net/viewvc/nusoap/lib/nusoap.php?revision=1.121&view=markup You may also consider dropping the requirement on PHP 4.2, I'm pretty sure every current build target in Fedora has a newer one. Only the license is a blocker, fix it and I can approve this package Spec URL: http://ke4qqq.fedorapeople.org/php-nusoap.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-nusoap-0.7.3-2.fc12.src.rpm I added blank lines for legibility, corrected license to LGPLv2+, and dropped version require of php to an unversioned php-common Official Review: * Naming is correct * License is good for Fedora * spec file legible * sources matches upstream * Mock build for F12 succeed APPROVED Thanks for the review Gianluca! New Package CVS Request ======================= Package Name: php-nusoap Short Description: SOAP toolkit for PHP Owners: ke4qqq Branches: EL-5 F-11 F-12 InitialCC: cvs done. php-nusoap-0.7.3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-nusoap-0.7.3-2.fc12 php-nusoap-0.7.3-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-nusoap-0.7.3-2.el5 php-nusoap-0.7.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-nusoap-0.7.3-2.fc11 php-nusoap-0.7.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. php-nusoap-0.7.3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. php-nusoap-0.7.3-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |