Spec URL: http://ke4qqq.fedorapeople.org/php-nusoap.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-nusoap-0.7.3-1.fc12.src.rpm Description: NuSOAP is a rewrite of SOAPx4, provided by NuSphere and Dietrich Ayala. It is a set of PHP classes - no PHP extensions required - that allow developers to create and consume web services based on SOAP 1.1, WSDL 1.1 and HTTP 1.0/1.1. [ke4qqq@nalleyx60 SPECS]$ rpmlint php-nusoap.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [ke4qqq@nalleyx60 SPECS]$ rpmlint ../RPMS/noarch/php-nusoap-0.7.3-1.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4qqq@nalleyx60 SPECS]$ rpmlint ../SRPMS/php-nusoap-0.7.3-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
I'll review this, one of my packages also bundles this lib
spec looks good, for more legibility I'd add some blank lines before %prep, %build and %install. One important thing though. I checked the license in nusoap.php and the correct one looks like LGPLv2+ http://nusoap.cvs.sourceforge.net/viewvc/nusoap/lib/nusoap.php?revision=1.121&view=markup You may also consider dropping the requirement on PHP 4.2, I'm pretty sure every current build target in Fedora has a newer one. Only the license is a blocker, fix it and I can approve this package
Spec URL: http://ke4qqq.fedorapeople.org/php-nusoap.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-nusoap-0.7.3-2.fc12.src.rpm I added blank lines for legibility, corrected license to LGPLv2+, and dropped version require of php to an unversioned php-common
Official Review: * Naming is correct * License is good for Fedora * spec file legible * sources matches upstream * Mock build for F12 succeed APPROVED
Thanks for the review Gianluca! New Package CVS Request ======================= Package Name: php-nusoap Short Description: SOAP toolkit for PHP Owners: ke4qqq Branches: EL-5 F-11 F-12 InitialCC:
cvs done.
php-nusoap-0.7.3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-nusoap-0.7.3-2.fc12
php-nusoap-0.7.3-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-nusoap-0.7.3-2.el5
php-nusoap-0.7.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-nusoap-0.7.3-2.fc11
php-nusoap-0.7.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
php-nusoap-0.7.3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
php-nusoap-0.7.3-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.