Bug 542559
Summary: | Review Request: rubygem-thor - Scripting framework that replaces rake, sake and rubigen | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthew Kent <mkent> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, jzigmund, mastahnke, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.12.0-2.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-12-31 07:47:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 541512, 541807 | ||
Bug Blocks: | 549286 |
Description
Matthew Kent
2009-11-30 07:03:57 UTC
Some notes: * Source - Source0 in srpm differs from what I could download from the URL written in the spec file ------------------------------------------------------------- 5fa79d6ca562a39c72c89f5447a3fbd5 thor-0.12.0.gem 32e034949be3726ff1857d0edeae6566 rubygem-thor-0.12.0-1.fc13.src/thor-0.12.0.gem ------------------------------------------------------------- (and the contents of two gems actually differ) * Requires - bin/rake2thor contains: ------------------------------------------------------------- 8 require 'rake' ------------------------------------------------------------- As the Summary of this spec file says "that replaces rake,", I think it is admitted to add "Requires: rubygem(rake)" and this should surely be added. - lib/thor/shell/color.rb contains: ------------------------------------------------------------- 98 @diff_lcs_loaded = begin 99 require 'diff/lcs' 100 true 101 rescue LoadError 102 false 103 end ------------------------------------------------------------- I guess "diff/lcs" dependency is surely optional, however as Fedora already has rubygem-diff-lcs, you may want to add this dependency (however this is up to what you think) Thank you for the review. (In reply to comment #1) > Some notes: > > * Source > - Source0 in srpm differs from what I could download from > the URL written in the spec file > ------------------------------------------------------------- > 5fa79d6ca562a39c72c89f5447a3fbd5 thor-0.12.0.gem > 32e034949be3726ff1857d0edeae6566 > rubygem-thor-0.12.0-1.fc13.src/thor-0.12.0.gem > ------------------------------------------------------------- > (and the contents of two gems actually differ) > Good catch! Looks like they replaced it after the recent rubyforge -> gemcutter migration. > * Requires > - bin/rake2thor contains: > ------------------------------------------------------------- > 8 require 'rake' > ------------------------------------------------------------- > As the Summary of this spec file says "that replaces rake,", > I think it is admitted to add "Requires: rubygem(rake)" and > this should surely be added. > Yeah I went back and forth on this one a bit initial, but your right, it should be there. > - lib/thor/shell/color.rb contains: > ------------------------------------------------------------- > 98 @diff_lcs_loaded = begin > 99 require 'diff/lcs' > 100 true > 101 rescue LoadError > 102 false > 103 end > ------------------------------------------------------------- > I guess "diff/lcs" dependency is surely optional, however > as Fedora already has rubygem-diff-lcs, you may want to > add this dependency (however this is up to what you think) Oh, missed this one. Looks like a minimal impact to add it as diff-lcs doesn't have any dependencies of its own. Spec URL: http://magoazul.com/wip/SPECS/rubygem-thor.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-thor-0.12.0-2.fc13.src.rpm * Fri Dec 18 2009 Matthew Kent <mkent> - 0.12.0-2 - Add Requires for rubygem(rake) (#542559). - Upstream replaced Source after the gemcutter migration, update to latest (#542559). - Add Requires for rubygem(diff-lcs) as Thor can take advantage of it for colourized diff output (#542559). Okay. -------------------------------------------------------- This package (rubygem-thor) is APPROVED by mtasaka -------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-thor Short Description: Scripting framework that replaces rake, sake and rubigen Owners: mkent Branches: F-11 F-12 InitialCC: CVS done rubygem-thor-0.12.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-thor-0.12.0-2.fc11 rubygem-thor-0.12.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-thor-0.12.0-2.fc12 Closing. rubygem-thor-0.12.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-thor-0.12.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-thor New Branches: el5 el6 Owners: stahnma mkent is aware of request. Git done (by process-git-requests). Hi, Could you update this gem to the newest version ? |