Bug 545334
| Summary: | Invalid XML can cause hard to decipher entity errors | ||
|---|---|---|---|
| Product: | [Community] Publican | Reporter: | Dana Mison <dmison> |
| Component: | publican | Assignee: | Jeff Fearn 🐞 <jfearn> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 2.3 | CC: | anross, dlackey, jfearn, mmcallis, publican-list, rlandman |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-29 01:39:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dana Mison
2009-12-08 08:07:31 UTC
The problem here is that the wrong error message is being generated. When you feed Publican invalid XML that matches the above format the entity parsing code chokes on it before the XML validation can flag it as invalid. This is because the entities are expanded prior to validation to ensure the full tree is being validated. I'm looking in to how to get the correct error message to be generated. The workaround is to use valid XML. e.g <code>&allproperties;</code> *** Bug 546488 has been marked as a duplicate of this bug. *** ah ; .. face->palm thanks :-) I have tracked this to a bug in HTML::Element::_xml_escape. The regex in this function seems too aggressive. (In reply to comment #4) > I have tracked this to a bug in HTML::Element::_xml_escape. The regex in this > function seems too aggressive. This is wrong. The issue is in the way the XML parser is parsing the XML when you have particular kinds of entities or invalid XML. I'm not sure there is anyway to properly flag this since the XML can not be validated before it is parsed ... will put this on the shelf for a bit. Finally tracked this down and worked out how to over come this bug, am pestering upstream to get a fix for XML::TreeBuilder. This message is a reminder that Fedora 12 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 12. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '12'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 12's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 12 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Bumped requirement for XML::TreeBuilder to 4.0, which contains fixes for this issue. Fixed in revision 1697 Required modules were updated some time ago. |