Bug 547916
| Summary: | Review Request: fedora-kde-icon-theme - Default icon theme for KDE Desktops on fedora | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Kevin Kofler <kevin> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-05 21:35:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 547701 | ||
|
Description
Rex Dieter
2009-12-16 00:52:31 UTC
Once reviewed, this move will also require changes in fedora-logos (and generic-logos) to reflect it's new location. I can take care of that... I'm going to review this, looks fairly straightforward at a first glance. ping ? Uh, sorry, my Internet connection at home broke down, so I have only limited connectivity at the moment. :-( I'll see what I can do. First observation: rpmlint has no complaints, that's nice. :-) MUST Items:
+ rpmlint output is blank ("0 errors, 0 warnings")
+ named and versioned according to the naming guidelines
+ Name matches spec name
+ package meets Packaging Guidelines
+ License: GPLv2+ and CC-BY-SA valid, matches actual license
+ COPYING.* included as %doc
+ spec file in American English and legible
+ source matches upstream:
MD5: 81ef91585e5d0356f127559cc4477f6e
SHA1: ebe1295cd05cce7fe53a4c8a83ff1db183d3ff28
SHA256: c539f2150ee8fc0bce40291d0ab1169790128e82c5473d252e21bba08e4e1324
+ builds successfully (Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1896041 )
+ no ExcludeArch needed
+ no missing BRs
+ no translations, shared libraries, bundled system libraries
+ not relocatable
+ all created directories (not already owned by filesystem) owned
+ all files listed only once
+ permissions are sane, %defattr used properly
+ %clean section present and valid
+ macros used consistently
+ the packaged content is permissible under CodeVsContent (icon theme)
+ no large documentation files => no -doc subpackage needed
+ %doc files not required at runtime
+ no header files, static libraries, .pc files, .so files, -devel subpackage, .la files or GUI applications
+ does not own files or directories already owned by another package
+ rm -rf %{buildroot} run at the beginning of %install
+ all filenames are valid UTF-8
SHOULD Items:
+ license texts already included in the tarball
+ no translated summary and description available, so none needs to be provided
+ builds in mock (Koji scratch build)
* arch-independent, so expected to build on all architectures, skipping all arch test
* skipping functionality test
+ scriptlets are sane, match standard snippets
+ no subpackages => no versioned deps on the base package needed
+ no .pc files
+ no file dependencies
Nitpick: Please add README as %doc as it contains part of the licensing information. But this is trivial and can be addressed after the import.
APPROVED
New Package CVS Request ======================= Package Name: fedora-kde-icon-theme Short Description: Default Icon theme for KDE Desktops on fedora Owners: rdieter Branches: InitialCC: cvs done. imported, thanks! |