Bug 549286

Almost forgot the rpmlint!

mkent@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint /var/tmp/rpmbuild/SRPMS/rubygem-merb-core-1.0.15-1.magoazul.src.rpm /var/tmp/results/rubygem-merb-core-*
rubygem-merb-core-doc.noarch: W: no-documentation                                                                                                                                                                
rubygem-merb-core-doc.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/merb-core-1.0.15/ri/Merb/Rack/Console/reload%21-i.yaml %21
<snip misspelled-macro warnings in -doc>
4 packages and 0 specfiles checked; 0 errors, 100 warnings.

The example provided by you works for me.

Some remarks:

* Requires
  Would you check if the following dependencies are
  not needed?

  - ebb
    from lib/merb-core/rack/adapter/ebb.rb

  - ruby-debug
    from lib/merb-core/config.rb

  - ruby-prof
    from lib/merb-core/core_ext/kernel.rb
         lib/merb-core/rack/middleware/profiler.rb

  - swiftiply
    from lib/merb-core/rack/adapter/evented_mongrel.rb
         lib/merb-core/rack/adapter/swiftiplied_mongrel.rb

  - thin
    from lib/merb-core/rack/adapter/thin.rb

  - thin-turbo (could not find on gems.rubyforge.org)
    from lib/merb-core/rack/adapter/thin_turbo.rb

  - webrat
    from lib/merb-core/test.rb

  - webrick
    from lib/merb-core/rack/adapter/webrick.rb

Thank you for the review!

(In reply to comment #2)
> The example provided by you works for me.
> 
> Some remarks:
> 
> * Requires
>   Would you check if the following dependencies are
>   not needed?
> 
>   - ebb
>     from lib/merb-core/rack/adapter/ebb.rb
> 

merb supports multiple frontend webservers via adapters and the -a parameter:

"The rack adapter to use to run merb (default is mongrel)[mongrel, emongrel, thin, ebb, fastcgi, webrick]"

As they use mongrel by default I chose to add it as a dependency and none of the others. Not having those gems installed doesn't inhibit functionality of the app.

The gem doesn't depend on any adapter at all oddly enough, though one could use webrick that ships with ruby itself.

>   - ruby-debug
>     from lib/merb-core/config.rb
> 

No package for this currently, though it looks useful. Doesn't look to block the main function of merb-core though and isn't listed as a primary or development dependency.

I'll add to my list of things to package.

>   - ruby-prof
>     from lib/merb-core/core_ext/kernel.rb
>          lib/merb-core/rack/middleware/profiler.rb
> 

No package for this currently, though it looks useful. Doesn't look to block the main function of merb-core though and isn't listed as a primary or development dependency.

I'll add to my list of things to package.

>   - swiftiply
>     from lib/merb-core/rack/adapter/evented_mongrel.rb
>          lib/merb-core/rack/adapter/swiftiplied_mongrel.rb
> 
>   - thin
>     from lib/merb-core/rack/adapter/thin.rb
> 
>   - thin-turbo (could not find on gems.rubyforge.org)
>     from lib/merb-core/rack/adapter/thin_turbo.rb
> 

See above note about adapters. Will look into the thin-turbo issue and file a ticket if necessary.

>   - webrat
>     from lib/merb-core/test.rb

The Rakefile lists it as a development dependency and I believe it's only required to run the merb test suite which isn't in this version. I'll be sure to revisit it when the next version of merb, which appears to come with the test suite, is released.

>   - webrick
>     from lib/merb-core/rack/adapter/webrick.rb  

This ships with ruby, though actually using it as an adapter doesn't seem to work with my example (404's each time). I should file an upstream bug for this.

(In reply to comment #3)
> Thank you for the review!
> 
> (In reply to comment #2)
> >   - ruby-debug
> >     from lib/merb-core/config.rb
> > 
> 
> No package for this currently, though it looks useful. Doesn't look to block
> the main function of merb-core though and isn't listed as a primary or
> development dependency.
> 
> I'll add to my list of things to package.
> 

Scratch this - is available in Bug 532306

So would you tell me if rubygem-ruby-debug review request (or
other rubygem dependencies) are currently the strict blocker
for this review request or not?

(In reply to comment #5)
> So would you tell me if rubygem-ruby-debug review request (or
> other rubygem dependencies) are currently the strict blocker
> for this review request or not?  

Nothing blocking right now. merb-core, as is, should be able to run applications with the listed dependencies in the spec file.

Thanks, so as the packaging itself is okay (and the test you
provided works), I can approve this one.

----------------------------------------------------------------
   This package (rubygem-merb-core) is APPROVED by mtasaka
----------------------------------------------------------------

New Package CVS Request
=======================
Package Name: rubygem-merb-core
Short Description: Lightweight Ruby-based MVC framework for web development
Owners: mkent
Branches: F-11 F-12
InitialCC:

cvs done.

rubygem-merb-core-1.0.15-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-merb-core-1.0.15-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: mkent
New Branches: el5 el6
Owners: stahnma

mkent is aware of request.

I think the package name is not right here. ;) 

Please re-check and reset the fedora-cvs flag.

Package Change Request
======================
Package Name: rubygem-merb-core
New Branches: el5 el6
Owners: stahnma

Sorry about that. I did about 25 of these at once, figure I may have messed up a couple.

Git done (by process-git-requests).