Well,

* License
  - I guess the license for this package should
    be "GPL+ or Ruby or Artistic".

* rcov for %check
  - build.log says:
-------------------------------------------------------
    89  + rake test
    90  Hoe.new {...} deprecated. Switch to Hoe.spec.
    91  (in /builddir/build/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
    92  which: no dot in (/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/usr/local/sbin)
    93  /usr/bin/ruby -w -Ilib:ext:bin:test -e 'require "rubygems"; require "test/unit"; require "test/test_mime_type.rb"; require "test/test_mime_types.rb"' 
    94  RCov is not available. In order to run rcov, you must: sudo gem install spicycode-rcov
-------------------------------------------------------
    I don't know well about RCov, however when I install
    rubygem-rcov, rake check fails as:
-------------------------------------------------------
[tasaka1@localhost mime-types-1.16]$ rake test --trace
(in /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
Hoe.new {...} deprecated. Switch to Hoe.spec.
rake aborted!
undefined method `test_files' for #<Hoe:0xb75d9a78>
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:53
/usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/lib/rcov/rcovtask.rb:91:in `initialize'
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51:in `new'
/home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `load'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `raw_load_rakefile'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2016:in `load_rakefile'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in `standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2015:in `load_rakefile'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1999:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in `standard_exception_handling'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1997:in `run'
/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
/usr/bin/rake:19:in `load'
/usr/bin/rake:19
-------------------------------------------------------
  ref: http://bugs.gentoo.org/288996
  Would you check this?

(In reply to comment #1)
> Well,
> 
> * License
>   - I guess the license for this package should
>     be "GPL+ or Ruby or Artistic".
> 

Sure! Fixed.

> * rcov for %check
>   - build.log says:
> -------------------------------------------------------
>     89  + rake test
>     90  Hoe.new {...} deprecated. Switch to Hoe.spec.
>     91  (in
> /builddir/build/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
>     92  which: no dot in
> (/usr/sbin:/usr/bin:/sbin:/bin:/usr/X11R6/bin:/root/bin:/usr/local/sbin)
>     93  /usr/bin/ruby -w -Ilib:ext:bin:test -e 'require "rubygems"; require
> "test/unit"; require "test/test_mime_type.rb"; require
> "test/test_mime_types.rb"' 
>     94  RCov is not available. In order to run rcov, you must: sudo gem install
> spicycode-rcov
> -------------------------------------------------------
>     I don't know well about RCov, however when I install
>     rubygem-rcov, rake check fails as:
> -------------------------------------------------------
> [tasaka1@localhost mime-types-1.16]$ rake test --trace
> (in
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16)
> Hoe.new {...} deprecated. Switch to Hoe.spec.
> rake aborted!
> undefined method `test_files' for #<Hoe:0xb75d9a78>
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:53
> /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/lib/rcov/rcovtask.rb:91:in `initialize'
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51:in
> `new'
> /home/tasaka1/rpmbuild/BUILD/rubygem-mime-types-1.16/usr/lib/ruby/gems/1.8/gems/mime-types-1.16/Rakefile:51
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `load'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2382:in `raw_load_rakefile'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2016:in `load_rakefile'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in
> `standard_exception_handling'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2015:in `load_rakefile'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1999:in `run'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2067:in
> `standard_exception_handling'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1997:in `run'
> /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
> /usr/bin/rake:19:in `load'
> /usr/bin/rake:19
> -------------------------------------------------------
>   ref: http://bugs.gentoo.org/288996
>   Would you check this?  

Rcov will produce a pretty report of the test coverage but is by no means necessary for the unit tests themselves. 

As to the error it looks like the Rakefile wants a specific version of rcov, 

p.extra_dev_deps  << %w(rcov ~>0.8)

while Fedora is on 0.9.6. I'll file a ticket with the upstream project about updating it to something more recent.

Spec URL: http://magoazul.com/wip/SPECS/rubygem-mime-types.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-mime-types-1.16-2.fc13.src.rpm

* Sun Dec 27 2009 Matthew Kent <mkent> - 1.16-2
- Fix license (#544964).
- Add note about rcov warning in test phase (#544964).

Well, what I am concerned here is that $ rake test actually
_fails_ is Fedora rubygem-rcov is installed (as I wrote in the
comment 2), not just warnings, so people who has rubygem-rcov installed
cannot rebuild your srpm, which I think should be avoided.

It seem that the following line
--------------------------------------------------
    53      t.test_files = hoe.test_files
--------------------------------------------------
in Rakefile seems unneeded. Would you again check this?

(In reply to comment #4)
> Well, what I am concerned here is that $ rake test actually
> _fails_ is Fedora rubygem-rcov is installed (as I wrote in the
> comment 2), not just warnings, so people who has rubygem-rcov installed
> cannot rebuild your srpm, which I think should be avoided.
> 
> It seem that the following line
> --------------------------------------------------
>     53      t.test_files = hoe.test_files
> --------------------------------------------------
> in Rakefile seems unneeded. Would you again check this?  

Ah sorry, you're 100% right - I forget people may build without mock. I'll remove the line during the test phase.

Seems the rcov task isn't necessary at all, newer versions of hoe provide the exact same thing in lib/hoe/rcov.rb.

Spec URL: http://magoazul.com/wip/SPECS/rubygem-mime-types.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-mime-types-1.16-3.fc13.src.rpm

* Wed Dec 30 2009 Matthew Kent <mkent> - 1.16-3
- Remove needless rcov task in Rakefile causing issue (#544964).

One thing
- The part ">= 1.8.3" of "BR(check): rubygem(hoe)" is not needed
  unless you want to import this package into EPEL because
  rubygem-hoe packages in currently supported branches of Fedora all
  satisfy this version.

  ref: the last sentence of
  https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
  (not a blocker)

-------------------------------------------------------------
  This package (rubygem-mime-types) is APPROVED by mtasaka
-------------------------------------------------------------

(In reply to comment #7)
> One thing
> - The part ">= 1.8.3" of "BR(check): rubygem(hoe)" is not needed
>   unless you want to import this package into EPEL because
>   rubygem-hoe packages in currently supported branches of Fedora all
>   satisfy this version.
> 
>   ref: the last sentence of
>   https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
>   (not a blocker)
>

Oops, thanks - missed that one.
 
> -------------------------------------------------------------
>   This package (rubygem-mime-types) is APPROVED by mtasaka
> -------------------------------------------------------------  

Thanks for the review.

New Package CVS Request
=======================
Package Name: rubygem-mime-types
Short Description: Return the MIME Content-Type for a given filename
Owners: mkent
Branches: F-11 F-12
InitialCC:

cvs done.

rubygem-mime-types-1.16-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/rubygem-mime-types-1.16-3.fc11

rubygem-mime-types-1.16-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-mime-types-1.16-3.fc12

Closing.

rubygem-mime-types-1.16-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-mime-types-1.16-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Hi, could you please push this package to F14/EL6 branch ?

Package Change Request
======================
Package Name: rubygem-mime-type
New Branches: el5 el6 
Owners: stahnma

Package Change Request
======================
Package Name: rubygem-mime-types
New Branches: el5 el6 
Owners: stahnma

mkent is aware of request.

Git done (by process-git-requests).

Package Change Request
======================
Package Name: rubygem-mime-types
New Branches: epel7
Owners: tdawson

Git done (by process-git-requests).