Bug 549763

Feedback on patchset:


diff -urpN a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
--- a/drivers/scsi/lpfc/lpfc_sli.c	(revision 7089)
+++ b/drivers/scsi/lpfc/lpfc_sli.c	(revision 7090)
@@ -1384,13 +1384,13 @@ lpfc_sli_hbq_to_firmware_s4(struct lpfc_
r7024.patch:

FYI - Some garbage at the end of the patch.  I'll clean this up this time.

r7092_r7090.patch and r7100_r7098.patch:

/* HBQ for ELS and CT traffic. */
 static struct lpfc_hbq_init lpfc_els_hbq = {
 	.rn = 1,
-	.entry_count = 200,
+	.entry_count = 256,
 	.mask_count = 0,
 	.profile = 0,
 	.ring_mask = (1 << LPFC_ELS_RING),
 	.buffer_count = 0,
-	.init_count = 40,
-	.add_count = 40,
+	.init_count = 256,
+	.add_count = 0,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Looks like this hunk gets done in r7092_r7090.patch and then undone in r7100_r7098.patch.  This could get called out as undesireable when this gets posted internally - fair warning.
 };


r7157.patch:

The code in patch file r7157.patch doesn't seem to match upstream.  Was another patch applied upstream that doesn't apply in rhel5.5 or visa-versa?

Can this be reconciled or is this due to dirvergence between the code streams?

(In reply to comment #1)
> Feedback on patchset:
> 
> 

Vaios,

Can you please comment on comment 1?

Thanks, Rob

1. "r7024.patch - Some garbage at the end of the patch."
This was a bug in our scripting that builds the individual patches, and it also escaped our manual verification. We updated our script to remove these extraneous messages.

2. "Looks like this hunk gets done in r7092_r7090.patch and then undone in r7100_r7098.patch"
This is an unavoidable side effect of the fact we build separate patches for each functional/bug fix checkin in the driver codebase. So, there will be cases where same code segments might be manipulated in different patches. That is another reason the patches in the provided patchset will need to be installed incrementally based on the version of the patch file.

3. "The code in patch file r7157.patch doesn't seem to match upstream.  Was another patch applied upstream that doesn't apply in rhel5.5 or visa-versa?
Can this be reconciled or is this due to dirvergence between the 
code streams?"
The code in this patch does not apply to upstream kernels, as it only applies to 2.6.18 and older kernels. This was for an issue that manifests itself whan a module is sending some inquiry commands which do not use scatter gather list. This bug fix handles the case of non scatter gather I/O requests. Later kernels always use scatter gather lists.

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.

New Contents:
The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.52.

Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.

Diffed Contents:
@@ -1 +1 @@
-The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.52.+The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.63.

~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~

RHEL 5.5 Beta has been released! There should be a fix present in this 
release that addresses your request. Please test and report back results 
here, by March 3rd 2010 (2010-03-03) or sooner.

Upon successful verification of this request, post your results and update 
the Verified field in Bugzilla with the appropriate value.

If you encounter any issues while testing, please describe them and set 
this bug into NEED_INFO. If you encounter new defects or have additional 
patch(es) to request for inclusion, please clone this bug per each request
and escalate through your support representative.

As of today, we are well beyond testing RHEL5.5 Beta and this driver version 8.2.0.63. At this point our DVT is testing Snap3 and the final 8.2.0.63.3p driver version.

So far the testing looks good. And yes, we are testing/qualifying in our DVT lab w/ every beta or snapshot  that is released.

-Vaios-

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html