Bug 549763 - [Emulex 5.5 bug] Update lpfc driver to 8.2.0.63 FC/FCoE
Summary: [Emulex 5.5 bug] Update lpfc driver to 8.2.0.63 FC/FCoE
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: 5.5
Assignee: Rob Evers
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 460949 533941 5.5TechNotes-Updates 562871
TreeView+ depends on / blocked
 
Reported: 2009-12-22 15:54 UTC by Vaios Papadimitriou
Modified: 2013-01-11 02:39 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.63.
Clone Of:
Environment:
Last Closed: 2010-03-30 07:25:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
LPFC 8.2.0.59 to 8.2.0.63 patch (6.18 KB, application/x-gzip)
2009-12-22 15:54 UTC, Vaios Papadimitriou
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Vaios Papadimitriou 2009-12-22 15:54:36 UTC
Created attachment 379851 [details]
LPFC 8.2.0.59 to 8.2.0.63 patch

Patch to update Emulex lpfc driver to 8.2.0.63 (applies on top of
8.2.0.59, see Bug 529244).

These are the changes included in this patch-set. Each change listed here corresponds to an individual patch:

- Fix vport not logging out when being deleted (CR 96339)
- Update lpfc version for 8.2.0.60 driver release
- Made OneConnect UCNA set up and use single FCP EQ only under INTx interrupt mode (CR 96645)
- Blocked all SCSI I/O requests from midlayer until target rediscovery during EEH (CR 95889)
- Fix bug with driver crashing during unload and SLI4 aborting a ct cmd. (CR 96598)
- Fix vport fails to register VPI after devloss timeout. (CR 96740)
- Update lpfc version for 8.2.0.61 driver release
- Fixed adapter reset and offline/online stress test failing with I/O errors (CR 92904)
- Fix multi-frame sequence response frames go to wrong DID (CR 96915)
- Fixed hbq buff adds to receive queue.
- Fixed hbq buff only for SLI4
- Update lpfc version for 8.2.0.62 driver release
- Fixed fc header seq_count checks. (CR 97010)
- Fix driver tries to process failed read FCF record.
- Fix vport->fc_flag set outside of lock caused I/O failure during pci-func reset (CR 96975)
- Fix Dead FCF not triggering discovery of other FCF.
- Fix single SCSI buffer is not handled for SLI4 adapters
- Update lpfc version for 8.2.0.63 driver release

Comment 1 Rob Evers 2009-12-22 21:34:11 UTC
Feedback on patchset:


diff -urpN a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
--- a/drivers/scsi/lpfc/lpfc_sli.c	(revision 7089)
+++ b/drivers/scsi/lpfc/lpfc_sli.c	(revision 7090)
@@ -1384,13 +1384,13 @@ lpfc_sli_hbq_to_firmware_s4(struct lpfc_
r7024.patch:

FYI - Some garbage at the end of the patch.  I'll clean this up this time.

r7092_r7090.patch and r7100_r7098.patch:

/* HBQ for ELS and CT traffic. */
 static struct lpfc_hbq_init lpfc_els_hbq = {
 	.rn = 1,
-	.entry_count = 200,
+	.entry_count = 256,
 	.mask_count = 0,
 	.profile = 0,
 	.ring_mask = (1 << LPFC_ELS_RING),
 	.buffer_count = 0,
-	.init_count = 40,
-	.add_count = 40,
+	.init_count = 256,
+	.add_count = 0,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Looks like this hunk gets done in r7092_r7090.patch and then undone in r7100_r7098.patch.  This could get called out as undesireable when this gets posted internally - fair warning.
 };


r7157.patch:

The code in patch file r7157.patch doesn't seem to match upstream.  Was another patch applied upstream that doesn't apply in rhel5.5 or visa-versa?

Can this be reconciled or is this due to dirvergence between the code streams?

Comment 2 Rob Evers 2010-01-04 15:34:47 UTC
(In reply to comment #1)
> Feedback on patchset:
> 
> 

Vaios,

Can you please comment on comment 1?

Thanks, Rob

Comment 3 Vaios Papadimitriou 2010-01-04 22:09:56 UTC
1. "r7024.patch - Some garbage at the end of the patch."
This was a bug in our scripting that builds the individual patches, and it also escaped our manual verification. We updated our script to remove these extraneous messages.

2. "Looks like this hunk gets done in r7092_r7090.patch and then undone in r7100_r7098.patch"
This is an unavoidable side effect of the fact we build separate patches for each functional/bug fix checkin in the driver codebase. So, there will be cases where same code segments might be manipulated in different patches. That is another reason the patches in the provided patchset will need to be installed incrementally based on the version of the patch file.

3. "The code in patch file r7157.patch doesn't seem to match upstream.  Was another patch applied upstream that doesn't apply in rhel5.5 or visa-versa?
Can this be reconciled or is this due to dirvergence between the 
code streams?"
The code in this patch does not apply to upstream kernels, as it only applies to 2.6.18 and older kernels. This was for an issue that manifests itself whan a module is sending some inquiry commands which do not use scatter gather list. This bug fix handles the case of non scatter gather I/O requests. Later kernels always use scatter gather lists.

Comment 5 RHEL Program Management 2010-01-08 19:41:00 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 9 Rob Evers 2010-02-09 16:02:56 UTC
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.

New Contents:
The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.52.

Comment 10 Rob Evers 2010-02-09 16:03:21 UTC
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.

Diffed Contents:
@@ -1 +1 @@
-The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.52.+The lpfc driver for Emulex Fibre Channel Host Bus Adapters has been updated to version 8.2.0.63.

Comment 11 Chris Ward 2010-02-11 10:34:22 UTC
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~

RHEL 5.5 Beta has been released! There should be a fix present in this 
release that addresses your request. Please test and report back results 
here, by March 3rd 2010 (2010-03-03) or sooner.

Upon successful verification of this request, post your results and update 
the Verified field in Bugzilla with the appropriate value.

If you encounter any issues while testing, please describe them and set 
this bug into NEED_INFO. If you encounter new defects or have additional 
patch(es) to request for inclusion, please clone this bug per each request
and escalate through your support representative.

Comment 32 Vaios Papadimitriou 2010-03-10 15:45:03 UTC
As of today, we are well beyond testing RHEL5.5 Beta and this driver version 8.2.0.63. At this point our DVT is testing Snap3 and the final 8.2.0.63.3p driver version.

So far the testing looks good. And yes, we are testing/qualifying in our DVT lab w/ every beta or snapshot  that is released.

-Vaios-

Comment 34 errata-xmlrpc 2010-03-30 07:25:09 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.