Bug 550104

Summary: Review Request: magento - Magento is an ecommerce web application.
Product: [Fedora] Fedora Reporter: Frederic Hornain <fhornain>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: alagunambiwelkin, cwickert, fedora-package-review, notting, pahan, paul
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-17 10:27:45 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description Frederic Hornain 2009-12-23 10:38:28 EST
Spec URL: http://fhornain.fedorapeople.org/pkgs/magento/magento.spec
SRPM URL: http://fhornain.fedorapeople.org/pkgs/magento/magento-
Description: Magento is an ecommerce web application.

Since it is a web application, this electronic commerce browser works on many platforms, making your store application easily manageable from any location.

Magento is the perfect ecommerce browser for the sell professional
and novice alike.
Comment 1 Alagunambi Welkin 2009-12-27 07:14:26 EST

Just a quick review suggestion,

In magento.spec line no. 28 remove unwanted tabs

Alagunambi Welkin
Comment 2 Frederic Hornain 2009-12-29 08:21:26 EST
I will do the modifications next week and will be available  at least the 8th of January 2010.
Comment 3 Frederic Hornain 2010-01-04 02:53:15 EST
Dear *,

Suggestion made by Alagunambi Welkin have been achieved.
You can now download the new releases at the following URL : http://fhornain.fedorapeople.org/

The files are :   
- magento-  
- magento-
- magento-

Frederic ;)
Comment 4 Christoph Wickert 2010-01-09 16:26:10 EST
Some comments on your spec:

Words in summary should start with capital letters: "Ecommmerce Platform"

%description should have linebreaks at 80 chararkters, it fits on an 80x25 terminal.

I don't like the word "perfect" in the description, it sounds like advertising.

Your Requires: line is even longer than your description, this makes the spec hard to read. Please split this into several lines.

There are some redundant Requires:, e.g. you don't need mysql-libs when you already have mysql. Please check the list for other redundancies.

%setup -q -n %{name}-%{version} is the same as a simple %setup -q

Fixing permissions and removing the .cvsignore files should be done in %prep instead of %install.

Please preserve the timestamps of the original files by adding -p to cp and install. See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

Instead of using cp I'd perfer install because you can set the correct permissions, so you wont need the chmod command after install.

BTW: The chmod command is very long, please split this into several lines too

For magento.conf I'd prefer a a separate Source1 instead of creating it on the fly in the spec. But this is up to you.

Overall the legibility of the spec could be better if it was properly formatted. IMHO all Fedora specs should start from the template you get with rpmdev-newspec.

Last but not least please use rpmlint to check your spec and packages. It would have warned you about some issues I pointed out here.
Comment 5 Frederic Hornain 2010-01-11 15:09:25 EST
Dear Christoph,

I am going to do the modification as soon as possible.

Best Regards
Frederic ;)
Comment 6 Jason Tibbitts 2010-11-14 13:46:30 EST
Looks like those modifications never happened.
Comment 7 Frederic Hornain 2010-11-15 05:02:05 EST
I am going to see if I can fix that asap.
My apologies for the delay.

Frederic ;)