Spec URL: http://fhornain.fedorapeople.org/pkgs/magento/magento.spec SRPM URL: http://fhornain.fedorapeople.org/pkgs/magento/magento-1.3.2.4-1.fc11.src.rpm Description: Magento is an ecommerce web application. Since it is a web application, this electronic commerce browser works on many platforms, making your store application easily manageable from any location. Magento is the perfect ecommerce browser for the sell professional and novice alike.
Hi, Just a quick review suggestion, In magento.spec line no. 28 remove unwanted tabs Alagunambi Welkin
I will do the modifications next week and will be available at least the 8th of January 2010.
Dear *, Suggestion made by Alagunambi Welkin have been achieved. You can now download the new releases at the following URL : http://fhornain.fedorapeople.org/ The files are : - magento-1.3.2.4-2.fc11.noarch.rpm - magento-1.3.2.4-2.fc11.src.rpm - magento-1.3.2.4-2.spec BR Frederic ;)
Some comments on your spec: Words in summary should start with capital letters: "Ecommmerce Platform" %description should have linebreaks at 80 chararkters, it fits on an 80x25 terminal. I don't like the word "perfect" in the description, it sounds like advertising. Your Requires: line is even longer than your description, this makes the spec hard to read. Please split this into several lines. There are some redundant Requires:, e.g. you don't need mysql-libs when you already have mysql. Please check the list for other redundancies. %setup -q -n %{name}-%{version} is the same as a simple %setup -q Fixing permissions and removing the .cvsignore files should be done in %prep instead of %install. Please preserve the timestamps of the original files by adding -p to cp and install. See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps Instead of using cp I'd perfer install because you can set the correct permissions, so you wont need the chmod command after install. BTW: The chmod command is very long, please split this into several lines too For magento.conf I'd prefer a a separate Source1 instead of creating it on the fly in the spec. But this is up to you. Overall the legibility of the spec could be better if it was properly formatted. IMHO all Fedora specs should start from the template you get with rpmdev-newspec. Last but not least please use rpmlint to check your spec and packages. It would have warned you about some issues I pointed out here.
Dear Christoph, I am going to do the modification as soon as possible. Best Regards Frederic ;)
Looks like those modifications never happened.
I am going to see if I can fix that asap. My apologies for the delay. BR Frederic ;)