Bug 550369
| Summary: | Review Request: spill - A segregated package install logical linker | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | spill-0.8-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-30 02:13:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-12-24 19:53:01 UTC
Review: Good: - license ok - %files ok - %doc ok - permissions ok - parallel make - name ok - url ok - buildroot ok - no BR/R ok - no *.la - no libs - rpmlint clean Comment: Is there a reason, why not using %makeinstall? from https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used "%makeinstall is a kludge that can work with Makefiles that don't make use of the DESTDIR variable" There is no DESTDIR variable, and %makeinstall works (only wrong permissions, that can be fixed after that or/and complained upstream.) Doing the install like this is ok, too; but I prefer %makeinstall in this case... So please consider changing to %makeinstall :) ################################################# APPROVED Thanks for the review. I will switch to %makeinstall. New Package CVS Request ======================= Package Name: spill Short Description: A segregated package install logical linker Owners: fab Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py). spill-0.8-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/spill-0.8-2.fc12 spill-0.8-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/spill-0.8-2.fc13 spill-0.8-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/spill-0.8-2.fc11 spill-0.8-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spill'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/spill-0.8-2.fc13 spill-0.8-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spill'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/spill-0.8-2.fc12 spill-0.8-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spill'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/spill-0.8-2.fc11 spill-0.8-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. spill-0.8-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. spill-0.8-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |