Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/spill.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/spill-0.8-1.fc12.src.rpm Project URL: http://www.rc0.org.uk/spill Description: spill is a program for creating set of symbolic links from one directory hierarchy which point to corresponding filenames in a separate directory hierarchy. It's primary use is to allow packages built from source to be installed in separate directory trees, which are all linked together under a common directory tree (e.g. /usr/local) to reduce the length of the PATH environment variable. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1890668 rpmlint output: [fab@localhost i686]$ rpmlint spill* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@localhost SRPMS]$ rpmlint spill-0.8-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Review: Good: - license ok - %files ok - %doc ok - permissions ok - parallel make - name ok - url ok - buildroot ok - no BR/R ok - no *.la - no libs - rpmlint clean Comment: Is there a reason, why not using %makeinstall? from https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used "%makeinstall is a kludge that can work with Makefiles that don't make use of the DESTDIR variable" There is no DESTDIR variable, and %makeinstall works (only wrong permissions, that can be fixed after that or/and complained upstream.) Doing the install like this is ok, too; but I prefer %makeinstall in this case... So please consider changing to %makeinstall :) ################################################# APPROVED
Thanks for the review. I will switch to %makeinstall.
New Package CVS Request ======================= Package Name: spill Short Description: A segregated package install logical linker Owners: fab Branches: F-11 F-12 InitialCC:
CVS done (by process-cvs-requests.py).
spill-0.8-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/spill-0.8-2.fc12
spill-0.8-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/spill-0.8-2.fc13
spill-0.8-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/spill-0.8-2.fc11
spill-0.8-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spill'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/spill-0.8-2.fc13
spill-0.8-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spill'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/spill-0.8-2.fc12
spill-0.8-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spill'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/spill-0.8-2.fc11
spill-0.8-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
spill-0.8-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
spill-0.8-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.