Bug 551042
| Summary: | Review Request: apache-commons-math - Java library of lightweight mathematics and statistics components | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mohamed El Morabity <pikachu.2014> |
| Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | akurtako, fedora-package-review, notting, overholt, susi.lehtola, tcallawa |
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-12 15:56:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mohamed El Morabity
2009-12-28 15:59:47 UTC
I would change the Summary to "A library of lightweight, self-contained mathematics and statistics components" which is IMHO a lot more descriptive than just "The Apache Commons Mathematics Library". Besides, isn't the name of the package wrong? I don't think there should be any "jakarta-" in it... Thanks for your comment about the summary, I'll update immediately my .spec file. About the name of the package, I followed the "implicit" convention in Fedora to prefix packages names of Java components from Apache Commons (http://commons.apache.org/) with "jakarta-commons-". It seems to be a legacy of JPackage. For example, Apache Commons projects like CLI or Codec are available in the repos as jakarta-commons-cli and jakarta-commons-codec. I updated the Summary as suggested; here are the updated .spec file and SRPM: Spec URL: http://melmorabity.fedorapeople.org/packages/jakarta-commons-math/jakarta-commons-math.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/jakarta-commons-math/jakarta-commons-math-2.0-2.fc12.src.rpm (In reply to comment #2) > Thanks for your comment about the summary, I'll update immediately my .spec > file. > > About the name of the package, I followed the "implicit" convention in Fedora > to prefix packages names of Java components from Apache Commons > (http://commons.apache.org/) with "jakarta-commons-". It seems to be a legacy > of JPackage. > For example, Apache Commons projects like CLI or Codec are available in the > repos as jakarta-commons-cli and jakarta-commons-codec. And we have to change that. Please make it apache-commons-math. New packages should to The Right Thing TM instead of following legacy practices. I changed the name of the package to "apache-commons-math" as suggested. The subject of the thread was updated therefore. Here are the new .spec file and SRPM: Spec URL: http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math-2.0-3.fc12.src.rpm Thanks for the submission. My review follows. Lines beginning with 'X' need work; lines beginning with '*' are good. I can sponsor you, too. There are just a few small issues and a legal question I have for Fedora Legal. * naming fine (I support the jakarta -> apache change) * builds on x86_64 fine * macros good * %files present and good * rpmlint output okay (ignore the maven fragment issue): $ rpmlint apache-commons-math-2.0-3.fc12.noarch.rpm apache-commons-math-javadoc-2.0-3.fc12.noarch.rpm apache-commons-math.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-math 2 packages and 0 specfiles checked; 0 errors, 1 warnings. X description too long (drop the Guiding Principles section) X license needs clarification: The license indicates there are some components that came from elsewhere or were derived from other implementation. Spot, can you clarify what the License field should read given the following license text: http://svn.apache.org/viewvc/commons/proper/math/trunk/LICENSE.txt?revision=799111 Thanks. Should be: License: ASL 1.1 and ASL 2.0 and BSD (Breakdown: Main license: ASL 2.0 minpack: ASL 1.1 odex: BSD (2 clause) lapack, mersenne: BSD (3 clause, without advertising) Lifting FE-Legal, please be sure to update License tag before approving. Thanks for these comments and reviews. This new version takes into account all of them: Spec URL: http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math-2.0-4.fc12.src.rpm This package is approved. Thanks, spot and Mohamed. Mohamed, please be sure to go through the appropriate steps to request sponsorship in the packager group. I will get an email when you've requested it. I'm sponsored you, Mohamed. New Package CVS Request ======================= Package Name: apache-commons-math Short Description: Java library of lightweight mathematics and statistics components Owners: melmorabity Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py) The package was uploaded to the CVS and built. Thanks to all reviewers :-) |