Bug 551042 - Review Request: apache-commons-math - Java library of lightweight mathematics and statistics components
Summary: Review Request: apache-commons-math - Java library of lightweight mathematics...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-28 15:59 UTC by Mohamed El Morabity
Modified: 2010-01-12 15:56 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-12 15:56:37 UTC
Type: ---
Embargoed:
overholt: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Mohamed El Morabity 2009-12-28 15:59:47 UTC
Spec URL: http://melmorabity.fedorapeople.org/packages/jakarta-commons-math/jakarta-commons-math.spec
SRPM URL: http://melmorabity.fedorapeople.org/packages/jakarta-commons-math/jakarta-commons-math-2.0-1.fc12.src.rpm
Description: Commons Math is a library of lightweight, self-contained mathematics and statistics components addressing the most common problems not available in the Java programming language or Commons Lang.

Guiding principles:
  1. Real-world application use cases determine development priority.
  2. This package emphasizes small, easily integrated components rather than large libraries with complex dependencies and configurations.
  3. All algorithms are fully documented and follow generally accepted best practices.
  4. In situations where multiple standard algorithms exist, a Strategy pattern is used to support multiple implementations.
  5. Limited dependencies. No external dependencies beyond Commons components and the core Java platform (at least Java 1.3 up to version 1.2 of the library, at least Java 5 starting with version 2.0 of the library).



mock is OK, rpmlint complains on this:
jakarta-commons-math.noarch: W: non-conffile-in-etc /etc/maven/fragments/jakarta-commons-math
Anyway, the Java guidelines about Maven-built sources don't consider this case, I suppose I can ignore this warning.

Note that I need a sponsor, although it's not my first package (see my other review request 551027).

Comment 1 Susi Lehtola 2009-12-29 16:43:02 UTC
I would change the Summary to "A library of lightweight, self-contained mathematics and statistics components" which is IMHO a lot more descriptive than just "The Apache Commons Mathematics Library".

Besides, isn't the name of the package wrong? I don't think there should be any "jakarta-" in it...

Comment 2 Mohamed El Morabity 2009-12-29 17:00:13 UTC
Thanks for your comment about the summary, I'll update immediately my .spec file.

About the name of the package, I followed the "implicit" convention in Fedora to prefix packages names of Java components from Apache Commons (http://commons.apache.org/) with "jakarta-commons-". It seems to be a legacy of JPackage.
For example, Apache Commons projects like CLI or Codec are available in the repos as jakarta-commons-cli and jakarta-commons-codec.

Comment 3 Mohamed El Morabity 2010-01-03 13:22:17 UTC
I updated the Summary as suggested; here are the updated .spec file and SRPM:

Spec URL:
http://melmorabity.fedorapeople.org/packages/jakarta-commons-math/jakarta-commons-math.spec
SRPM URL:
http://melmorabity.fedorapeople.org/packages/jakarta-commons-math/jakarta-commons-math-2.0-2.fc12.src.rpm

Comment 4 Alexander Kurtakov 2010-01-06 09:42:58 UTC
(In reply to comment #2)
> Thanks for your comment about the summary, I'll update immediately my .spec
> file.
> 
> About the name of the package, I followed the "implicit" convention in Fedora
> to prefix packages names of Java components from Apache Commons
> (http://commons.apache.org/) with "jakarta-commons-". It seems to be a legacy
> of JPackage.
> For example, Apache Commons projects like CLI or Codec are available in the
> repos as jakarta-commons-cli and jakarta-commons-codec. 

And we have to change that. Please make it apache-commons-math. New packages should to The Right Thing TM instead of following legacy practices.

Comment 5 Mohamed El Morabity 2010-01-06 10:12:13 UTC
I changed the name of the package to "apache-commons-math" as suggested. The subject of the thread was updated therefore.

Here are the new .spec file and SRPM:
Spec URL: http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math.spec
SRPM URL: http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math-2.0-3.fc12.src.rpm

Comment 6 Andrew Overholt 2010-01-07 19:29:54 UTC
Thanks for the submission.  My review follows.  Lines beginning with 'X' need work; lines beginning with '*' are good.  I can sponsor you, too.  There are just a few small issues and a legal question I have for Fedora Legal.

* naming fine (I support the jakarta -> apache change)
* builds on x86_64 fine
* macros good
* %files present and good
* rpmlint output okay (ignore the maven fragment issue):

$ rpmlint apache-commons-math-2.0-3.fc12.noarch.rpm apache-commons-math-javadoc-2.0-3.fc12.noarch.rpm
apache-commons-math.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-math
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

X description too long (drop the Guiding Principles section)
X license needs clarification:

The license indicates there are some components that came from elsewhere or were derived from other implementation.  Spot, can you clarify what the License field should read given the following license text:

http://svn.apache.org/viewvc/commons/proper/math/trunk/LICENSE.txt?revision=799111

Thanks.

Comment 7 Tom "spot" Callaway 2010-01-08 16:00:43 UTC
Should be:

License: ASL 1.1 and ASL 2.0 and BSD

(Breakdown:
Main license: ASL 2.0
minpack: ASL 1.1
odex: BSD (2 clause)
lapack, mersenne: BSD (3 clause, without advertising)

Lifting FE-Legal, please be sure to update License tag before approving.

Comment 8 Mohamed El Morabity 2010-01-08 16:27:06 UTC
Thanks for these comments and reviews. This new version takes into account all of them:
Spec URL:
http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math.spec
SRPM URL:
http://melmorabity.fedorapeople.org/packages/apache-commons-math/apache-commons-math-2.0-4.fc12.src.rpm

Comment 9 Andrew Overholt 2010-01-08 16:32:52 UTC
This package is approved.  Thanks, spot and Mohamed.

Mohamed, please be sure to go through the appropriate steps to request sponsorship in the packager group.  I will get an email when you've requested it.

Comment 10 Andrew Overholt 2010-01-11 14:20:16 UTC
I'm sponsored you, Mohamed.

Comment 11 Mohamed El Morabity 2010-01-11 18:29:43 UTC
New Package CVS Request
=======================
Package Name: apache-commons-math
Short Description: Java library of lightweight mathematics and statistics components
Owners: melmorabity
Branches: F-11 F-12
InitialCC:

Comment 12 Jason Tibbitts 2010-01-12 06:26:36 UTC
CVS done (by process-cvs-requests.py)

Comment 13 Mohamed El Morabity 2010-01-12 15:56:37 UTC
The package was uploaded to the CVS and built. Thanks to all reviewers :-)


Note You need to log in before you can comment on or make changes to this bug.