Bug 551722
| Summary: | Review Request: php-channel-phpmd - PHP Mess Detector PEAR channel | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christof Damian <christof> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, guillaume, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.3-3.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-26 01:03:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 551724 | ||
|
Description
Christof Damian
2010-01-01 14:39:53 UTC
Again ;)
- Requires php-cli is redundant with php-pear
- replace pear.phpmd.org.xml by %{name}.xml (cf PHP Guidelines)
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpmd.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpmd-1.3-1.fc12.src.rpm - removed php-cli requirement, which is covered by php-pear requirement - changed name of channel xml name - using rest version as version now Spec URL: http://rpms.damian.net/SPECS/php-channel-phpmd.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpmd-1.3-2.fc12.src.rpm forgot to change channel xml filename in %post in %post: missing .xml after %{name}
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpmd.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpmd-1.3-3.fc12.src.rpm REVIEW * no source files (channel.xml match latest upstream) * package meets naming * package must meet packaging guidelines * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license (of the packages provided by the channel). * license is open source-compatible (BSD). * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide). * package installs properly * channel (un)registered properly * rpmlint (warnings are ok) : php-channel-phpmd.src: I: checking php-channel-phpmd.noarch: I: checking php-channel-phpmd.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. * final provides are sane: php-channel(pear.phpmd.org) = 1.3 php-channel-phpmd = 1.3-3.fc8 + final requires /usr/bin/pear php-pear(PEAR) * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation * %install start with rm * %clean ok ***** APPROVED ***** New Package CVS Request ======================= Package Name: php-channel-phpmd Short Description: PHP Mess Detector PEAR channel Owners: cdamian Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py). php-channel-phpmd-1.3-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-channel-phpmd-1.3-3.fc12 php-channel-phpmd-1.3-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-channel-phpmd New Branches: EL-6 Owners: cdamian CVS done (by process-cvs-requests.py). Package Change Request ====================== Package Name: php-channel-phpmd New Branches: EL-7 Owners: llaumgui Git done (by process-git-requests). Can you please check, it seems epel7 branch doesn't exist. Package Change Request ====================== Package Name: php-channel-phpmd New Branches: epel7 Owners: llaumgui Git done (by process-git-requests). |