Bug 551722 - Review Request: php-channel-phpmd - PHP Mess Detector PEAR channel
Summary: Review Request: php-channel-phpmd - PHP Mess Detector PEAR channel
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 551724
TreeView+ depends on / blocked
 
Reported: 2010-01-01 14:39 UTC by Christof Damian
Modified: 2014-11-05 11:37 UTC (History)
4 users (show)

Fixed In Version: 1.3-3.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-26 01:03:54 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Christof Damian 2010-01-01 14:39:53 UTC
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpmd.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpmd-1.0.0-1.fc12.src.rpm
Description: PHP Mess Detector PEAR channel

Comment 1 Remi Collet 2010-01-02 08:01:18 UTC
Again ;)
- Requires php-cli is redundant with php-pear
- replace pear.phpmd.org.xml by %{name}.xml (cf PHP Guidelines)

Comment 2 Christof Damian 2010-01-24 09:13:20 UTC
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpmd.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpmd-1.3-1.fc12.src.rpm

- removed php-cli requirement, which is covered by php-pear requirement
- changed name of channel xml name
- using rest version as version now

Comment 3 Christof Damian 2010-01-24 12:09:49 UTC
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpmd.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpmd-1.3-2.fc12.src.rpm

forgot to change channel xml filename in %post

Comment 4 Remi Collet 2010-01-24 12:29:58 UTC
in %post: missing .xml after %{name}

Comment 6 Remi Collet 2010-01-24 15:43:09 UTC
REVIEW
* no source files (channel.xml match latest upstream)
* package meets naming 
* package must meet packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (of the packages provided by the
channel).
* license is open source-compatible (BSD).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide).
* package installs properly
* channel (un)registered properly
* rpmlint (warnings are ok) :
php-channel-phpmd.src: I: checking
php-channel-phpmd.noarch: I: checking
php-channel-phpmd.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
* final provides are sane:
php-channel(pear.phpmd.org) = 1.3
php-channel-phpmd = 1.3-3.fc8
+ final requires
/usr/bin/pear  
php-pear(PEAR)  
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation 
* %install start with rm
* %clean ok


***** APPROVED *****

Comment 7 Christof Damian 2010-01-24 15:53:19 UTC
New Package CVS Request
=======================
Package Name: php-channel-phpmd
Short Description: PHP Mess Detector PEAR channel
Owners: cdamian
Branches: F-11 F-12
InitialCC:

Comment 8 Jason Tibbitts 2010-01-24 17:32:20 UTC
CVS done (by process-cvs-requests.py).

Comment 9 Fedora Update System 2010-01-24 20:20:47 UTC
php-channel-phpmd-1.3-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/php-channel-phpmd-1.3-3.fc12

Comment 10 Fedora Update System 2010-01-26 01:03:50 UTC
php-channel-phpmd-1.3-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Christof Damian 2010-07-04 11:20:10 UTC
Package Change Request
======================
Package Name: php-channel-phpmd
New Branches: EL-6
Owners: cdamian

Comment 12 Kevin Fenzi 2010-07-05 01:41:44 UTC
CVS done (by process-cvs-requests.py).

Comment 13 Guillaume Kulakowski 2014-11-03 09:32:02 UTC
Package Change Request
======================
Package Name: php-channel-phpmd
New Branches: EL-7
Owners: llaumgui

Comment 14 Gwyn Ciesla 2014-11-03 12:58:53 UTC
Git done (by process-git-requests).

Comment 15 Remi Collet 2014-11-04 06:59:32 UTC
Can you please check, it seems epel7 branch doesn't exist.

Comment 16 Remi Collet 2014-11-04 07:03:05 UTC
Package Change Request
======================
Package Name: php-channel-phpmd
New Branches: epel7
Owners: llaumgui

Comment 17 Gwyn Ciesla 2014-11-05 11:37:07 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.