Bug 551724
Summary: | Review Request: php-phpmd-PHP-PMD - PHPMD - PHP Mess Detector | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christof Damian <christof> |
Component: | Package Review | Assignee: | Christof Damian <christof> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora, fedora-package-review, guillaume, notting |
Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.2.2-2.fc12 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-02-02 01:11:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 551722, 551723 | ||
Bug Blocks: |
Description
Christof Damian
2010-01-01 14:42:54 UTC
forgot description: Spec URL: http://rpms.damian.net/SPECS/php-phpmd-PHP-PMD.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpmd-PHP-PMD-0.2.0-1.fc12.src.rpm Description: PHPMD - PHP Mess Detector new upstream release: Spec URL: http://rpms.damian.net/SPECS/php-phpmd-PHP-PMD.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpmd-PHP-PMD-0.2.1-1.fc12.src.rpm Description: PHPMD - PHP Mess Detector First/quick notes - Replace %define by %global (I have miss this on previous reviews...) - use %{channel} in %postun - use %{pear_datadir} instead of %{pear_phpdir}/data All docs should be in /usr/share/doc/php-phpmd-PHP-PMD-0.2.1 Most of pear package use (what is generated by pear make-rpm-spec): after install: mv $RPM_BUILD_ROOT%{pear_docdir}/* docdir and in %file %doc %{pear_name}-%{version}/docdir/%{pear_name}/* In fact, Guidelines need to be clearer about this, so Waiting for a reply to http://lists.fedoraproject.org/pipermail/packaging/2010-January/006845.html According to package.xml this requires dom extension According to pci this requires libxml and SimpleXML So, replace Requires: php-common >= 5.2.0 With Requires: php-xml >= 5.2.0 (In reply to comment #3) > First/quick notes > > - Replace %define by %global (I have miss this on previous reviews...) > - use %{channel} in %postun > - use %{pear_datadir} instead of %{pear_phpdir}/data all done. I will replace the define while doing other updates on the other packages. > > All docs should be in /usr/share/doc/php-phpmd-PHP-PMD-0.2.1 > > Most of pear package use (what is generated by pear make-rpm-spec): > > after install: > mv $RPM_BUILD_ROOT%{pear_docdir}/* docdir > > and in %file > %doc %{pear_name}-%{version}/docdir/%{pear_name}/* That makes sense. (In reply to comment #4) > According to package.xml this requires dom extension > According to pci this requires libxml and SimpleXML > > So, replace > Requires: php-common >= 5.2.0 > With > Requires: php-xml >= 5.2.0 I added the php-xml. I prefer to have the php-common requirement with the php version number and the separate requirement for php-xml, because it makes the spec file more readable. Is that ok too? Or is there a guideline to reduce the requires to a minimum? I also upgraded to the new upstream bugfix release: Spec URL: http://rpms.damian.net/SPECS/php-phpmd-PHP-PMD.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpmd-PHP-PMD-0.2.2-1.fc12.src.rpm > Or is there a guideline to reduce the requires to a minimum? Well... I don't find anything. I think the use of minimal Requires is a good practice (which also reduce the size of the repo metadata) > because it makes the spec file more readable. Ok. Seems you have forget to upload the new files... (In reply to comment #6) > Seems you have forget to upload the new files... Oops, wrong server. I just moved my hosting. REVIEW: + rpmlint is ok php-phpmd-PHP-PMD.noarch: I: checking php-phpmd-PHP-PMD.src: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + provided license file + sources match the upstream sources 9c76d49df7137b52332267b76bb11f64 PHP_PMD-0.2.2.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear >= 1:1.6.0, php-channel(pear.phpmd.org)) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation not required to run + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + test suite ok (can't be run during build) + scriptlets ok + Final Requires ok /usr/bin/pear /usr/bin/php php-channel(pear.phpmd.org) php-common >= 5.2.0 php-pear(pear.pdepend.org/PHP_Depend) >= 0.9.7 php-xml + Final Provides ok php-pear(pear.phpmd.org/PHP_PMD) = 0.2.2 php-phpmd-PHP-PMD = 0.2.2-1.fc8 + Build in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1954558 + run ok in %file, should use %{pear_datadir}/PHP_PMD instead of %{pear_phpdir}/data/PHP_PMD ===== APPROVED ===== (In reply to comment #8) > > in %file, should use %{pear_datadir}/PHP_PMD instead of > %{pear_phpdir}/data/PHP_PMD I will change that before the import > ===== APPROVED ===== Thank you for the review. New Package CVS Request ======================= Package Name: php-phpmd-PHP-PMD Short Description: PHPMD - PHP Mess Detector Owners: cdamian Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py). php-phpmd-PHP-PMD-0.2.2-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-phpmd-PHP-PMD-0.2.2-2.fc11 php-phpmd-PHP-PMD-0.2.2-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-phpmd-PHP-PMD-0.2.2-2.fc12 php-phpmd-PHP-PMD-0.2.2-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. php-phpmd-PHP-PMD-0.2.2-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-phpmd-PHP-PMD New Branches: EL-6 Owners: cdamian CVS done (by process-cvs-requests.py). Package Change Request ====================== Package Name: php-phpmd-PHP-PMD New Branches: EL-7 Owners: llaumgui Git done (by process-git-requests). Can you please check, it seems epel7 branch doesn't exist. Package Change Request ====================== Package Name: php-phpmd-PHP-PMD New Branches: epel7 Owners: llaumgui Git done (by process-git-requests). |