Bug 553127

Summary: Merge Review: perl-Sub-Uplevel - Apparently run a function in a higher stack frame
Product: [Fedora] Fedora Reporter: Marcela Mašláňová <mmaslano>
Component: Package ReviewAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, jskarvad, mmaslano, notting
Target Milestone: ---Flags: jskarvad: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-04 08:51:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2010-01-07 07:56:09 UTC 
SRPM: http://kojipkgs.fedoraproject.org/packages/perl-Sub-Uplevel/0.2002/4.fc13/src/perl-Sub-Uplevel-0.2002-4.fc13.src.rpm
Spec: http://koji.fedoraproject.org/koji/fileinfo?rpmID=1712222&filename=perl-Sub-Uplevel.spec
Description: Like Tcl's uplevel() function, but not quite so dangerous. The idea is just to fool caller(). All the really naughty bits of Tcl's uplevel() are avoided.
Comment 1 Jaroslav Škarvada 2010-01-27 14:59:47 UTC 
MUST items:
[YES] rpmplint on spec and RPMs is silent
[YES] Package meets naming guidelines.
[YES] Package meets packaging guidelines.
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file.
[YES] Licensing Guidelines are met.
[YES] Spec file is legible and in American English.
[YES] Sources match upstream.
[YES] Package builds OK.
[YES] BuildRequires is correct.
[YES] Package doesn't bundle copies of system libraries.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[YES] %clean section is correct.
[YES] Spec file has consistant macro usage.
[YES] Package is code or permissable content.
[YES] %doc files don't affect runtime.
[YES] No .la libtool archives.
[YES][Perl] Package doesn't own files/directories that other packages own.
[YES] Package has rm -rf $RPM_BUILD_ROOT at beginning of %install.
[YES] All files are valid UTF-8.

Should items:
[YES] Package builds in mock.
[YES] Package uses sane scriptlets.
[YES] Package contains man pages.