Bug 553127 - Merge Review: perl-Sub-Uplevel - Apparently run a function in a higher stack frame
Summary: Merge Review: perl-Sub-Uplevel - Apparently run a function in a higher stack ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-07 07:56 UTC by Marcela Mašláňová
Modified: 2010-02-04 08:51 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-02-04 08:51:52 UTC
Type: ---
Embargoed:
jskarvad: fedora-review+


Attachments (Terms of Use)

Description Marcela Mašláňová 2010-01-07 07:56:09 UTC
SRPM: http://kojipkgs.fedoraproject.org/packages/perl-Sub-Uplevel/0.2002/4.fc13/src/perl-Sub-Uplevel-0.2002-4.fc13.src.rpm
Spec: http://koji.fedoraproject.org/koji/fileinfo?rpmID=1712222&filename=perl-Sub-Uplevel.spec
Description: Like Tcl's uplevel() function, but not quite so dangerous. The idea is just to fool caller(). All the really naughty bits of Tcl's uplevel() are avoided.

Comment 1 Jaroslav Škarvada 2010-01-27 14:59:47 UTC
MUST items:
[YES] rpmplint on spec and RPMs is silent
[YES] Package meets naming guidelines.
[YES] Package meets packaging guidelines.
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file.
[YES] Licensing Guidelines are met.
[YES] Spec file is legible and in American English.
[YES] Sources match upstream.
[YES] Package builds OK.
[YES] BuildRequires is correct.
[YES] Package doesn't bundle copies of system libraries.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[YES] %clean section is correct.
[YES] Spec file has consistant macro usage.
[YES] Package is code or permissable content.
[YES] %doc files don't affect runtime.
[YES] No .la libtool archives.
[YES][Perl] Package doesn't own files/directories that other packages own.
[YES] Package has rm -rf $RPM_BUILD_ROOT at beginning of %install.
[YES] All files are valid UTF-8.

Should items:
[YES] Package builds in mock.
[YES] Package uses sane scriptlets.
[YES] Package contains man pages.


Note You need to log in before you can comment on or make changes to this bug.