Bug 554088
| Summary: | Review Request: pybox2d - A 2D rigid body simulation library for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sebastian Dziallas <sebastian> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-13 21:34:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 554089, 554090 | ||
|
Description
Sebastian Dziallas
2010-01-10 12:23:30 UTC
Spec URL: http://sdz.fedorapeople.org/rpmbuild/pybox2d.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/pybox2d-2.0.2-2.20100110svn.fc12.src.rpm Here's a new build that makes use of setuptools and includes a previously missing file. Review: Good: - name ok - license ok - sources match upstream (diff -r clean) - BR ok (testbed needs some more, but that is not needed) - rpmlint clean $ rpmlint pybox2d-2.0.2-2.20100110svn.fc12.src.rpm x86_64/pybox2d-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - %clean is there - %install ok (calm rpmlint down, can't be moved to %prep) - description ok - permissions ok - %files ok - builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1913399 Needswork: - How to create the tarball... Copy paste of your command does not work... Remove the '|' and it'll work. 'cd pybox2d' before svn export is also missing. - use global and not define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - why is the group devel/languages? Development/Libraries would be more appropriate. - %doc: please add 'doc/*' The online link for the manual is dead... Shipping is the only solution to get the manual. ######################### Change the group to Development/Libraries, the rest is 'should'. ######################### APPROVED New Package CVS Request ======================= Package Name: pybox2d Short Description: A 2D rigid body simulation library for Python Owners: sdz Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py) Built in Rawhide - updates submitted. |