Spec URL: http://sdz.fedorapeople.org/rpmbuild/python-elements.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/python-elements-0.13-1.20100110svn.fc12.src.rpm Description: This is a dependency for the Sugar Physics activity. Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1912040
To be honest, the review can be mostly copy & paste from pybox2d... Review: Good: - name ok - license ok - sources match upstream (diff -r clean) - BR ok - rpmlint clean $ rpmlint python-elements-0.13-1.20100110svn.fc12.src.rpm noarch/python-elements-0.13-1.20100110svn.fc12.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - %clean is there - %install ok (calm rpmlint down, can't be moved to %prep) - description ok - permissions ok - %files ok - builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1914151 Needswork: - How to create the tarball... Copy paste of your command does not work... Remove the '|' and it'll work. - calm rpmlint down in %prep and not in %install -> sed -i elements/elements.py -e 1d - use global and not define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - why is the group devel/languages? Development/Libraries would be more appropriate. ######################### Change the group to Development/Libraries and calm rpmlint down in %prep, the rest is 'should'. ######################### APPROVED
New Package CVS Request ======================= Package Name: python-elements Short Description: A 2D Physics API for Python Owners: sdz Branches: F-11 F-12 InitialCC:
Thanks for the reviews! :) I'll import the fixed versions once the branch has been created.
CVS done (by process-cvs-requests.py)
Built in Rawhide with updates on the way, thanks again for the reviews!