Bug 554886
| Summary: | hal-disable-polling --device /dev/<symlink> dies horrid death | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Valdis Kletnieks <valdis.kletnieks> | ||||
| Component: | hal | Assignee: | Richard Hughes <rhughes> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 13 | CC: | atkac, jvcelak, martin, mrunge, ndevos, nexor, pahan, psj, richard, thomas.mey, unixro | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 710920 (view as bug list) | Environment: | |||||
| Last Closed: | 2011-06-27 14:47:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Valdis Kletnieks
2010-01-12 22:05:27 UTC
Created attachment 398772 [details]
Proposed patch
Problem is quite simple. Second realpath(3) argument is too short. It should be at least PATH_MAX bytes (which is currently 4096 B), not HAL_PATH_MAX (512 B). Patch fixes this issue and, I believe, is better than original approach with fixed-length array.
This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle. Changing version to '13'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Confirming the same bug with Fedora 13 and hal-0.5.14-3.fc13.x86_64. powertop advised me to execute that command, I expect lots of people will hit the same bug :-/ The workaround as mentioned in the opening comment works for me too: # hal-disable-polling --device $(readlink -f /dev/cdrom) *** Bug 611136 has been marked as a duplicate of this bug. *** *** Bug 582761 has been marked as a duplicate of this bug. *** The same problem on F13 and Rawhide. Please, can you fix this bug ASAP? This makes profile switching in tuned to crash. I can confirm this problem for recent F14 hal-0.5.14-4.fc14.i686 naming the device by its correct name (not the symlink) hal-disable-polling seems to work fine. Another me too: # hal-disable-polling --enable-polling --device /dev/scd0 *** buffer overflow detected ***: hal-disable-polling terminated Aborted (core dumped) Workaround: # hal-disable-polling --enable-polling --device $(readlink -f /dev/scd0) Polling for drive /dev/sr0 have been enabled. The fdi file deleted was /etc/hal/fdi/information/media-check-disable-storage_model_DVDRAM_GSA_U20N.fdi hal-0.5.14-5.fc15.x86_64 Fedora Rawhide. *** Bug 639497 has been marked as a duplicate of this bug. *** This message is a reminder that Fedora 13 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 13. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '13'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 13's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 13 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Fedora 16 will very likely not contain hal anymore and therefore will obsolete this bug: - https://fedoraproject.org/wiki/Features/HalRemoval *** Bug 577526 has been marked as a duplicate of this bug. *** Fedora 13 changed to end-of-life (EOL) status on 2011-06-25. Fedora 13 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. |