Bug 555187
Summary: | Review Request: taggle - An online french word game | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Florent Le Coz <louizatakk> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, louiz, mtasaka, notting, pikachu.2014, tcallawa, tomspur |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.9-1.fc12 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-02-05 16:56:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Florent Le Coz
2010-01-13 23:19:49 UTC
> Is there a problem with the fact that this package is mostly for french users > (translated only in french, and the game is based on a french dictionnary)? I think it should at least provide the package information US English as well, according to [1] this is required. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description (In reply to comment #1) > > Is there a problem with the fact that this package is mostly for french users > > (translated only in french, and the game is based on a french dictionnary)? > > I think it should at least provide the package information US English as well, > according to [1] this is required. > > [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description The package information (summary, description, etc) ARE in US English. (everything in the spec file is in english) What is in french is the software itself, but I don't see any guidelines that talks about the language the software should be in. So, I assume this is not a problem BUT I could be wrong. First of all, this package does not build. Please fix build failure: http://koji.fedoraproject.org/koji/taskinfo?taskID=1929974 http://koji.fedoraproject.org/koji/taskinfo?taskID=1929975 You can use "mock" to make it sure that your package surely builds from a "clean" buildroot: http://fedoraproject.org/wiki/Extras/MockTricks (In reply to comment #0) > Is there a problem with the fact that this package is mostly for french users > (translated only in french, and the game is based on a french dictionnary)? There are already numbers of packages which are used in some region specific. (In reply to comment #3) > First of all, this package does not build. Please fix > build failure: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=1929974 > http://koji.fedoraproject.org/koji/taskinfo?taskID=1929975 The GroupLayout layout is only available since the version 6 of the JDK. But it seems that gcj (that uses the Classpath library) is used by default to build this package, and Classpath implements only (and almost) the JDK 5 API. A JDK 6-complient Java implementation (on Fedora, typically OpenJDK)must be used instead to compile and run this package. As described here: http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires modify your "BuildRequires" on java-devel and "Requires" on java like this: BuildRequires: java-devel >= 1:1.6.0 Requires: java >= 1:1.6.0 Thank you both for you advices. Here is a new version of the package, successfully built using Mock. I just fixed the "BuildRequires" and "Requires". Spec URL: http://louizatakk.fedorapeople.org/rpm/baggle.spec SRPM URL: http://louizatakk.fedorapeople.org/rpm/baggle-0.8-4.fc12.src.rpm "Boggle" is a live trademark of Hasbro, both in a board game application and an electronic game application. http://tess2.uspto.gov/bin/showfield?f=doc&state=4004:q9ap2d.2.19 http://tess2.uspto.gov/bin/showfield?f=doc&state=4004:q9ap2d.2.9 I do not believe it is permitted to call something in Fedora a "Boggle game", and "B@ggle" is almost certainly too close to the mark to be permitted as a package name. Of course, I'm not a lawyer; blocking FE-Legal for advice. Yeah, this will need to be renamed to be acceptable. Spec URL: http://louizatakk.fedorapeople.org/rpm/bagel.spec SRPM URL: http://louizatakk.fedorapeople.org/rpm/bagel-0.8-6.fc12.src.rpm Description: Bagel is an online french word game that lets you play against your friends. Letters are displayed at random in a grid and players attempt to find words in sequence of adjacent letters This is the renaming of baggle. The new name for the package (bagel) was decided by upstream (http://codingteam.net/project/baggle/bugs/show/1096 [Fr]). The trademark no longer appears in the .spec file and the old name (B@ggle) is replaced in all sources using sed. Lifting FE-Legal, thanks for the quick response. Some notes: * Obsoletes - Since baggle{,-server} packages are not yet imported into Fedora, these Obsoletes are not needed. * baggle -> bagel - Fix SOURCE2 (bagel.desktop) * About SOURCE2/4 - I guess using "exec" shell builtin is better like: ---------------------------------------------------------------- #!/bin/sh exec java -jar /usr/share/java/bagel-server.jar "$@" ---------------------------------------------------------------- * Requires - I guess ">= 1:1.6.0" on java dependency should added also in -server subpackage. * Undefined macro ---------------------------------------------------------------- mkdir -p %{buildroot}%{icondir} ---------------------------------------------------------------- - %icondir macro is defined nowhere, and it seems to be used nowhere anyway. (In reply to comment #10) Thank you, I fixed everything. Here is the new version : SRPM URL: http://louizatakk.fedorapeople.org/rpm/bagel-0.8-7.fc12.src.rpm Spec URL: http://louizatakk.fedorapeople.org/rpm/bagel.spec For -7: * Obsoletes/Provides - Please also remove baggle-server stuff. Oups… removed. SRPM URL: http://louizatakk.fedorapeople.org/rpm/bagel-0.8-8.fc12.src.rpm Spec URL: http://louizatakk.fedorapeople.org/rpm/bagel.spec -------------------------------------------------- This package (bagel) is APPROVED by mtasaka -------------------------------------------------- New Package CVS Request ======================= Package Name: bagel Short Description: An online french word game Owners: louizatakk Branches: F-11 F-12 InitialCC: Before we get into the same problems as we did with the multitude of different software named "surf", did anyone check for other software named "bagel"? I found at least: http://web.uconn.edu/townsend/software.html Can't find the source. http://bioinformatics.biol.rug.nl/websoftware/bagel/bagel_start.php Looks to be entirely web-based, probably not an issue. http://www2.ph.ed.ac.uk/~paboyle/bagel/ GPLv2, perhaps a bit esoteric but certainly worth considering for conflicts. Ok, renamed again: taggle (chosen by upstream) I found no conflict. new files: SRPM URL: http://louizatakk.fedorapeople.org/rpm/taggle-0.8-9.fc12.src.rpm Spec URL: http://louizatakk.fedorapeople.org/rpm/taggle.spec And if no conflict is found, a new CVS request. New Package CVS Request ======================= Package Name: taggle Short Description: An online french word game Owners: louizatakk Branches: F-11 F-12 InitialCC: CVS done (by process-cvs-requests.py). taggle-0.8-9.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/taggle-0.8-9.fc12 taggle-0.8-9.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/taggle-0.8-9.fc11 taggle-0.9-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/taggle-0.9-1.fc11 taggle-0.9-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/taggle-0.9-1.fc12 taggle-0.9-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update taggle'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1431 taggle-0.9-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update taggle'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1473 Closing. taggle-0.9-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. taggle-0.9-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |