Bug 555187 - Review Request: taggle - An online french word game
Summary: Review Request: taggle - An online french word game
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-13 23:19 UTC by Florent Le Coz
Modified: 2010-02-09 05:02 UTC (History)
7 users (show)

Fixed In Version: 0.9-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-05 16:56:13 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Florent Le Coz 2010-01-13 23:19:49 UTC
Spec URL: http://louizatakk.fedorapeople.org/rpm/baggle-0.8-3.fc12.src.rpm
SRPM URL: http://louizatakk.fedorapeople.org/rpm/baggle.spec

Description: B@ggle is an online french Boggle game that lets you play
against your friends.

It's my first package with sub-package
rpmlint is silent

Is there a problem with the fact that this package is mostly for french users (translated only in french, and the game is based on a french dictionnary)?

Also, still looking for a sponsor.

Comment 1 Dominic Hopf 2010-01-15 10:34:19 UTC
> Is there a problem with the fact that this package is mostly for french users
> (translated only in french, and the game is based on a french dictionnary)?

I think it should at least provide the package information US English as well,
according to [1] this is required.

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

Comment 2 Florent Le Coz 2010-01-15 14:27:22 UTC
(In reply to comment #1)
> > Is there a problem with the fact that this package is mostly for french users
> > (translated only in french, and the game is based on a french dictionnary)?
> 
> I think it should at least provide the package information US English as well,
> according to [1] this is required.
> 
> [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description    

The package information (summary, description, etc) ARE in US English. (everything in the spec file is in english)
What is in french is the software itself, but I don't see any guidelines that talks about the language the software should be in.
So, I assume this is not a problem BUT I could be wrong.

Comment 3 Mamoru TASAKA 2010-01-18 17:26:12 UTC
First of all, this package does not build. Please fix
build failure:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1929974
http://koji.fedoraproject.org/koji/taskinfo?taskID=1929975

You can use "mock" to make it sure that your package surely
builds from a "clean" buildroot:
http://fedoraproject.org/wiki/Extras/MockTricks

(In reply to comment #0)
> Is there a problem with the fact that this package is mostly for french users
> (translated only in french, and the game is based on a french dictionnary)?

There are already numbers of packages which are
used in some region specific.

Comment 4 Mohamed El Morabity 2010-01-18 23:03:35 UTC
(In reply to comment #3)
> First of all, this package does not build. Please fix
> build failure:
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1929974
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1929975
The GroupLayout layout is only available since the version 6 of the JDK. But it seems that gcj (that uses the Classpath library) is used by default to build this package, and Classpath implements only (and almost) the JDK 5 API.
A JDK 6-complient Java implementation (on Fedora, typically OpenJDK)must  be used instead to compile and run this package. As described here:
   http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires
modify your "BuildRequires" on java-devel and "Requires" on java like this:
   BuildRequires:	java-devel >= 1:1.6.0
   Requires:            java >= 1:1.6.0

Comment 5 Florent Le Coz 2010-01-19 18:50:08 UTC
Thank you both for you advices.
Here is a new version of the package, successfully built using Mock.
I just fixed the "BuildRequires" and "Requires".

Spec URL: http://louizatakk.fedorapeople.org/rpm/baggle.spec
SRPM URL: http://louizatakk.fedorapeople.org/rpm/baggle-0.8-4.fc12.src.rpm

Comment 6 Jason Tibbitts 2010-01-20 20:04:55 UTC
"Boggle" is a live trademark of Hasbro, both in a board game application and an electronic game application.

http://tess2.uspto.gov/bin/showfield?f=doc&state=4004:q9ap2d.2.19
http://tess2.uspto.gov/bin/showfield?f=doc&state=4004:q9ap2d.2.9

I do not believe it is permitted to call something in Fedora a "Boggle game", and "B@ggle" is almost certainly too close to the mark to be permitted as a package name.  Of course, I'm not a lawyer; blocking FE-Legal for advice.

Comment 7 Tom "spot" Callaway 2010-01-25 16:01:20 UTC
Yeah, this will need to be renamed to be acceptable.

Comment 8 Florent Le Coz 2010-01-26 14:25:42 UTC
Spec URL: http://louizatakk.fedorapeople.org/rpm/bagel.spec
SRPM URL: http://louizatakk.fedorapeople.org/rpm/bagel-0.8-6.fc12.src.rpm

Description: 
Bagel is an online french word game that lets you play
against your friends. Letters are displayed at random
in a grid and players attempt to find words in sequence
of adjacent letters


This is the renaming of baggle.

The new name for the package (bagel) was decided by upstream (http://codingteam.net/project/baggle/bugs/show/1096 [Fr]). The trademark no longer appears in the .spec file and the old name (B@ggle) is replaced in all sources using sed.

Comment 9 Tom "spot" Callaway 2010-01-26 14:45:41 UTC
Lifting FE-Legal, thanks for the quick response.

Comment 10 Mamoru TASAKA 2010-01-31 16:25:37 UTC
Some notes:

* Obsoletes
  - Since baggle{,-server} packages are not yet imported into
    Fedora, these Obsoletes are not needed.

* baggle -> bagel
  - Fix SOURCE2 (bagel.desktop)

* About SOURCE2/4
  - I guess using "exec" shell builtin is better like:
----------------------------------------------------------------
#!/bin/sh

exec java -jar /usr/share/java/bagel-server.jar "$@"
----------------------------------------------------------------

* Requires
  - I guess ">= 1:1.6.0" on java dependency should added
    also in -server subpackage.

* Undefined macro
----------------------------------------------------------------
mkdir -p %{buildroot}%{icondir}
----------------------------------------------------------------
  - %icondir macro is defined nowhere, and it seems to be
    used nowhere anyway.

Comment 11 Florent Le Coz 2010-01-31 17:44:43 UTC
(In reply to comment #10)

Thank you, I fixed everything.

Here is the new version :
SRPM URL: http://louizatakk.fedorapeople.org/rpm/bagel-0.8-7.fc12.src.rpm
Spec URL: http://louizatakk.fedorapeople.org/rpm/bagel.spec

Comment 12 Mamoru TASAKA 2010-01-31 18:06:30 UTC
For -7:

* Obsoletes/Provides
  - Please also remove baggle-server stuff.

Comment 14 Mamoru TASAKA 2010-01-31 19:31:32 UTC
--------------------------------------------------
  This package (bagel) is APPROVED by mtasaka
--------------------------------------------------

Comment 15 Florent Le Coz 2010-02-01 04:38:57 UTC
New Package CVS Request
=======================
Package Name: bagel
Short Description: An online french word game
Owners: louizatakk
Branches: F-11 F-12
InitialCC:

Comment 16 Jason Tibbitts 2010-02-01 20:51:17 UTC
Before we get into the same problems as we did with the multitude of different software named "surf", did anyone check for other software named "bagel"?  I found at least:

http://web.uconn.edu/townsend/software.html
  Can't find the source.
http://bioinformatics.biol.rug.nl/websoftware/bagel/bagel_start.php
  Looks to be entirely web-based, probably not an issue.
http://www2.ph.ed.ac.uk/~paboyle/bagel/
  GPLv2, perhaps a bit esoteric but certainly worth considering for conflicts.

Comment 17 Florent Le Coz 2010-02-01 22:25:06 UTC
Ok, renamed again: taggle (chosen by upstream)

I found no conflict.

new files:

SRPM URL: http://louizatakk.fedorapeople.org/rpm/taggle-0.8-9.fc12.src.rpm
Spec URL: http://louizatakk.fedorapeople.org/rpm/taggle.spec

And if no conflict is found, a new CVS request.

Comment 18 Florent Le Coz 2010-02-01 22:25:22 UTC
New Package CVS Request
=======================
Package Name: taggle
Short Description: An online french word game
Owners: louizatakk
Branches: F-11 F-12
InitialCC:

Comment 19 Kevin Fenzi 2010-02-01 22:53:19 UTC
CVS done (by process-cvs-requests.py).

Comment 20 Fedora Update System 2010-02-03 03:54:38 UTC
taggle-0.8-9.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/taggle-0.8-9.fc12

Comment 21 Fedora Update System 2010-02-03 03:55:34 UTC
taggle-0.8-9.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/taggle-0.8-9.fc11

Comment 22 Fedora Update System 2010-02-03 18:52:21 UTC
taggle-0.9-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/taggle-0.9-1.fc11

Comment 23 Fedora Update System 2010-02-03 18:53:10 UTC
taggle-0.9-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/taggle-0.9-1.fc12

Comment 24 Fedora Update System 2010-02-05 01:18:04 UTC
taggle-0.9-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update taggle'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1431

Comment 25 Fedora Update System 2010-02-05 01:34:05 UTC
taggle-0.9-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update taggle'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1473

Comment 26 Mamoru TASAKA 2010-02-05 16:56:13 UTC
Closing.

Comment 27 Fedora Update System 2010-02-09 05:00:25 UTC
taggle-0.9-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 28 Fedora Update System 2010-02-09 05:02:00 UTC
taggle-0.9-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.