Bug 555990
| Summary: | Review Request: rubygem-acts-as-list - Sorting and reordering capabilities for ActiveRecord model | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karel Klíč <kklic> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, fedora-package-review, mlists, notting, rvokal |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
a.badger: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-acts-as-list-0.1.2-4.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-11 08:57:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 499959 | ||
|
Description
Karel Klíč
2010-01-16 10:40:02 UTC
Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-2.fc12.src.rpm * Fri Feb 5 2010 Karel Klic <kklic> - 0.1.2-2 - Added %%check section - Removed unused macro %%ruby_sitelib - Gem is unpacked in %%prep section This package seems almost okay.
Well,
* Documents
- I think test/ tasks/ directories should also be marked as
%doc.
* activerecord dependendency
----------------------------------------------------------------
[tasaka1@localhost ~]$ irb
irb(main):001:0> require "rubygems"
=> true
irb(main):002:0> require "acts_as_list"
NameError: uninitialized constant ActiveRecord
from /usr/lib/ruby/gems/1.8/gems/acts-as-list-0.1.2/lib/acts_as_list.rb:254
from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
from (irb):2
from /usr/lib/ruby/site_ruby/1.8/rubygems/exceptions.rb:91
----------------------------------------------------------------
- I think lib/acts_as_list.rb should explicitly have 'require "active_record"'.
How do you think?
Agreed, lib/acts_as_list.rb should require Active Record. Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-3.fc12.src.rpm * Mon May 24 2010 Karel Klic <kklic> - 0.1.2-3 - Marked test and tasks directories as %%doc - Added patch to require Active Record Well,
* Please remove backup .requirear file from %buildroot (this file
is also copyed into %buildroot by "cp -a" as it is).
Please fix the above issue when importing this package into
Fedora CVS.
------------------------------------------------------------------
This package (rubygem-acts-as-tree) is APPROVED by mtasaka
------------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygems-acts-as-list Short Description: Sorting and reordering capabilities for Active Record models Owners: kklic Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). Please import this package into Fedora. I imported the package under wrong name (rubygems-acts-as-list). It should be named rubygem-acts-as-list. I'm sorry. Can that be fixed before importing the package into Fedora? I hope we will be able to avoid following https://fedoraproject.org/wiki/Package_Renaming_Process for this new, not-yet-imported package. Maybe file a ticket to rel-eng? Ah, I guess rel-eng team will help this case if you file a ticket for rel-eng. New Package CVS Request ======================= Package Name: rubygem-acts-as-list Short Description: Sorting and reordering capabilities for Active Record models Owners: kklic Branches: F-12 F-13 InitialCC: Okay, this should now be renamed. Tasaka-san, thank you for the review. rubygem-acts-as-list-0.1.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-acts-as-list-0.1.2-4.fc12 rubygem-acts-as-list-0.1.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-acts-as-list-0.1.2-4.fc13 rubygem-acts-as-list-0.1.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-acts-as-list-0.1.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |