Bug 555990 - Review Request: rubygem-acts-as-list - Sorting and reordering capabilities for ActiveRecord model
Summary: Review Request: rubygem-acts-as-list - Sorting and reordering capabilities fo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 499959
TreeView+ depends on / blocked
 
Reported: 2010-01-16 10:40 UTC by Karel Klíč
Modified: 2013-03-03 23:00 UTC (History)
5 users (show)

Fixed In Version: rubygem-acts-as-list-0.1.2-4.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-06-11 08:57:44 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
a.badger: fedora-cvs+


Attachments (Terms of Use)

Description Karel Klíč 2010-01-16 10:40:02 UTC
Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec
SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-1.fc12.src.rpm
Description:
Gem version of acts_as_list plugin for ActiveRecord.
Provides the capabilities for sorting and reordering a number 
of objects in a list.  The class that has this specified needs 
to have a position column defined as an integer on the mapped 
database table.

rpmlint ./rubygem-acts-as-list-0.1.2-1.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint ./rubygem-acts-as-list-0.1.2-1.fc12.noarch.rpm 
rubygem-acts-as-list.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/acts-as-list-0.1.2/ri/ActsAsList/InstanceMethods/first%3f-i.yaml %3f
rubygem-acts-as-list.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/acts-as-list-0.1.2/ri/ActsAsList/InstanceMethods/last%3f-i.yaml %3f
rubygem-acts-as-list.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/acts-as-list-0.1.2/ri/ActsAsList/InstanceMethods/in_list%3f-i.yaml %3f
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

In my opinion these warnings can be ignored.

The name of this package uses dashes because the gem also uses them.
The gem must be loaded to Rails using:
config.gem 'acts-as-list', :lib => 'acts_as_list'

Comment 1 Karel Klíč 2010-02-05 08:25:32 UTC
Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec
SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-2.fc12.src.rpm

* Fri Feb  5 2010 Karel Klic <kklic> - 0.1.2-2
- Added %%check section
- Removed unused macro %%ruby_sitelib
- Gem is unpacked in %%prep section

Comment 2 Mamoru TASAKA 2010-05-21 18:01:20 UTC
This package seems almost okay.

Well,

* Documents
  - I think test/ tasks/ directories should also be marked as
    %doc.

* activerecord dependendency
----------------------------------------------------------------
[tasaka1@localhost ~]$ irb
irb(main):001:0> require "rubygems"
=> true
irb(main):002:0> require "acts_as_list"
NameError: uninitialized constant ActiveRecord
	from /usr/lib/ruby/gems/1.8/gems/acts-as-list-0.1.2/lib/acts_as_list.rb:254
	from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
	from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
	from (irb):2
	from /usr/lib/ruby/site_ruby/1.8/rubygems/exceptions.rb:91
----------------------------------------------------------------
  - I think lib/acts_as_list.rb should explicitly have 'require "active_record"'.
    How do you think?

Comment 3 Karel Klíč 2010-05-24 09:52:13 UTC
Agreed, lib/acts_as_list.rb should require Active Record.

Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec
SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-3.fc12.src.rpm

* Mon May 24 2010 Karel Klic <kklic> - 0.1.2-3
- Marked test and tasks directories as %%doc
- Added patch to require Active Record

Comment 4 Mamoru TASAKA 2010-05-24 17:53:38 UTC
Well,

* Please remove backup .requirear file from %buildroot (this file
  is also copyed into %buildroot by "cp -a" as it is).

Please fix the above issue when importing this package into
Fedora CVS.

------------------------------------------------------------------
    This package (rubygem-acts-as-tree) is APPROVED by mtasaka
------------------------------------------------------------------

Comment 5 Karel Klíč 2010-05-27 13:39:39 UTC
New Package CVS Request
=======================
Package Name: rubygems-acts-as-list
Short Description: Sorting and reordering capabilities for Active Record models
Owners: kklic
Branches: F-12 F-13
InitialCC:

Comment 6 Jason Tibbitts 2010-05-27 22:37:09 UTC
CVS done (by process-cvs-requests.py).

Comment 7 Mamoru TASAKA 2010-06-06 17:02:37 UTC
Please import this package into Fedora.

Comment 8 Karel Klíč 2010-06-08 11:54:02 UTC
I imported the package under wrong name (rubygems-acts-as-list). It should be named rubygem-acts-as-list. I'm sorry.

Can that be fixed before importing the package into Fedora? 

I hope we will be able to avoid following https://fedoraproject.org/wiki/Package_Renaming_Process for this new, not-yet-imported package.

Maybe file a ticket to rel-eng?

Comment 9 Mamoru TASAKA 2010-06-08 13:47:03 UTC
Ah, I guess rel-eng team will help this case if you file a ticket
for rel-eng.

Comment 10 Karel Klíč 2010-06-08 14:28:11 UTC
https://fedorahosted.org/rel-eng/ticket/3782

Comment 11 Karel Klíč 2010-06-09 08:25:52 UTC
New Package CVS Request
=======================
Package Name: rubygem-acts-as-list
Short Description: Sorting and reordering capabilities for Active Record models
Owners: kklic
Branches: F-12 F-13
InitialCC:

Comment 12 Toshio Ernie Kuratomi 2010-06-11 06:13:45 UTC
Okay, this should now be renamed.

Comment 13 Karel Klíč 2010-06-11 08:57:44 UTC
Tasaka-san, thank you for the review.

Comment 14 Fedora Update System 2010-06-11 09:01:12 UTC
rubygem-acts-as-list-0.1.2-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-acts-as-list-0.1.2-4.fc12

Comment 15 Fedora Update System 2010-06-11 09:01:45 UTC
rubygem-acts-as-list-0.1.2-4.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/rubygem-acts-as-list-0.1.2-4.fc13

Comment 16 Fedora Update System 2010-06-14 17:14:26 UTC
rubygem-acts-as-list-0.1.2-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2010-06-14 17:27:44 UTC
rubygem-acts-as-list-0.1.2-4.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.