Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-1.fc12.src.rpm Description: Gem version of acts_as_list plugin for ActiveRecord. Provides the capabilities for sorting and reordering a number of objects in a list. The class that has this specified needs to have a position column defined as an integer on the mapped database table. rpmlint ./rubygem-acts-as-list-0.1.2-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint ./rubygem-acts-as-list-0.1.2-1.fc12.noarch.rpm rubygem-acts-as-list.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/acts-as-list-0.1.2/ri/ActsAsList/InstanceMethods/first%3f-i.yaml %3f rubygem-acts-as-list.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/acts-as-list-0.1.2/ri/ActsAsList/InstanceMethods/last%3f-i.yaml %3f rubygem-acts-as-list.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/acts-as-list-0.1.2/ri/ActsAsList/InstanceMethods/in_list%3f-i.yaml %3f 1 packages and 0 specfiles checked; 0 errors, 3 warnings. In my opinion these warnings can be ignored. The name of this package uses dashes because the gem also uses them. The gem must be loaded to Rails using: config.gem 'acts-as-list', :lib => 'acts_as_list'
Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-2.fc12.src.rpm * Fri Feb 5 2010 Karel Klic <kklic> - 0.1.2-2 - Added %%check section - Removed unused macro %%ruby_sitelib - Gem is unpacked in %%prep section
This package seems almost okay. Well, * Documents - I think test/ tasks/ directories should also be marked as %doc. * activerecord dependendency ---------------------------------------------------------------- [tasaka1@localhost ~]$ irb irb(main):001:0> require "rubygems" => true irb(main):002:0> require "acts_as_list" NameError: uninitialized constant ActiveRecord from /usr/lib/ruby/gems/1.8/gems/acts-as-list-0.1.2/lib/acts_as_list.rb:254 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from (irb):2 from /usr/lib/ruby/site_ruby/1.8/rubygems/exceptions.rb:91 ---------------------------------------------------------------- - I think lib/acts_as_list.rb should explicitly have 'require "active_record"'. How do you think?
Agreed, lib/acts_as_list.rb should require Active Record. Spec URL: http://kklic.fedorapeople.org/rubygem-acts-as-list.spec SRPM URL: http://kklic.fedorapeople.org/rubygem-acts-as-list-0.1.2-3.fc12.src.rpm * Mon May 24 2010 Karel Klic <kklic> - 0.1.2-3 - Marked test and tasks directories as %%doc - Added patch to require Active Record
Well, * Please remove backup .requirear file from %buildroot (this file is also copyed into %buildroot by "cp -a" as it is). Please fix the above issue when importing this package into Fedora CVS. ------------------------------------------------------------------ This package (rubygem-acts-as-tree) is APPROVED by mtasaka ------------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygems-acts-as-list Short Description: Sorting and reordering capabilities for Active Record models Owners: kklic Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Please import this package into Fedora.
I imported the package under wrong name (rubygems-acts-as-list). It should be named rubygem-acts-as-list. I'm sorry. Can that be fixed before importing the package into Fedora? I hope we will be able to avoid following https://fedoraproject.org/wiki/Package_Renaming_Process for this new, not-yet-imported package. Maybe file a ticket to rel-eng?
Ah, I guess rel-eng team will help this case if you file a ticket for rel-eng.
https://fedorahosted.org/rel-eng/ticket/3782
New Package CVS Request ======================= Package Name: rubygem-acts-as-list Short Description: Sorting and reordering capabilities for Active Record models Owners: kklic Branches: F-12 F-13 InitialCC:
Okay, this should now be renamed.
Tasaka-san, thank you for the review.
rubygem-acts-as-list-0.1.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-acts-as-list-0.1.2-4.fc12
rubygem-acts-as-list-0.1.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-acts-as-list-0.1.2-4.fc13
rubygem-acts-as-list-0.1.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-acts-as-list-0.1.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.