Bug 555991

Summary:	Review Request: compizconfig-backend-kconfig4 - Kconfig4 backend for compizconfig
Product:	[Fedora] Fedora	Reporter:	leigh scott <leigh123linux>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-04-08 14:09:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description leigh scott 2010-01-16 10:47:59 UTC

Spec URL: http://leigh123linux.fedorapeople.org/pub/review/compizconfig-backend-kconfig4/1/compizconfig-backend-kconfig4.spec
SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/compizconfig-backend-kconfig4/1/compizconfig-backend-kconfig4-0.8.4-1.fc12.src.rpm
Description: The Compiz Fusion Project brings 3D desktop visual effects that improve
usability of the X Window System and provide increased productivity
through plugins and themes contributed by the community giving a
rich desktop experience.

This package contains the Kconfig4 backend for libcompizconfig

Comment 1 Rex Dieter 2010-01-16 21:17:48 UTC

A few quick initial comments:
1.  probably only really need
BuildRequires: kdelibs4-devel
(unverified, unless you know better)

2.  in %install, use
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
intead

3.  in %install, no need for .la file hackery.  kde4/cmake produces none.

Comment 2 Rex Dieter 2010-01-16 21:30:24 UTC

$ rpmlint x86_64/*.rpm *.rpm
compizconfig-backend-kconfig4.x86_64: W: obsolete-not-provided compizconfig-backend-kconfig
compizconfig-backend-kconfig4-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package compizconfig-backend-kconfig4.
compizconfig-backend-kconfig4.src:15: W: unversioned-explicit-obsoletes compizconfig-backend-kconfig
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

Mostly harmless.

scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1927324

Builds/installs fine.

macro usage good, consistent.

License: GPLv2+  OK  (though you probably don't need to %doc COPYING.LGPL, unless I'm missing something)

no scriptlets.

source verified,
$ md5sum *.gz
d5aee115ad0d2f3586c359b1dac1d072  compizconfig-backend-kconfig4-0.8.4.tar.gz

Consider the items in initial comments as SHOULD items, but not review blockers.


APPROVED

Comment 3 leigh scott 2010-01-16 21:46:52 UTC

Thank you for review . 


New Package CVS Request
=======================
Package Name: compizconfig-backend-kconfig4
Short Description: Kconfig4 backend for libcompizconfig
Owners: leigh123linux
Branches: F-12
InitialCC: leigh123linux

Comment 4 Jason Tibbitts 2010-01-16 22:29:20 UTC

CVS done (by process-cvs-requests.py).

Comment 5 Rex Dieter 2010-02-23 19:46:40 UTC

ping, was this ever imported, can we close this?

Comment 6 leigh scott 2010-02-23 23:51:21 UTC

(In reply to comment #5)
> ping, was this ever imported, can we close this?    

Yes it was.

Comment 7 leigh scott 2011-04-05 16:00:07 UTC

Package Change Request
======================
Package Name: compizconfig-backend-kconfig4
New Branches: el6
Owners: leigh123linux

Comment 8 Jason Tibbitts 2011-04-05 17:54:01 UTC

Git done (by process-git-requests).