Spec URL: http://leigh123linux.fedorapeople.org/pub/review/compizconfig-backend-kconfig4/1/compizconfig-backend-kconfig4.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/compizconfig-backend-kconfig4/1/compizconfig-backend-kconfig4-0.8.4-1.fc12.src.rpm Description: The Compiz Fusion Project brings 3D desktop visual effects that improve usability of the X Window System and provide increased productivity through plugins and themes contributed by the community giving a rich desktop experience. This package contains the Kconfig4 backend for libcompizconfig
A few quick initial comments: 1. probably only really need BuildRequires: kdelibs4-devel (unverified, unless you know better) 2. in %install, use make install/fast DESTDIR=%{buildroot} -C %{_target_platform} intead 3. in %install, no need for .la file hackery. kde4/cmake produces none.
$ rpmlint x86_64/*.rpm *.rpm compizconfig-backend-kconfig4.x86_64: W: obsolete-not-provided compizconfig-backend-kconfig compizconfig-backend-kconfig4-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package compizconfig-backend-kconfig4. compizconfig-backend-kconfig4.src:15: W: unversioned-explicit-obsoletes compizconfig-backend-kconfig 3 packages and 0 specfiles checked; 1 errors, 2 warnings. Mostly harmless. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1927324 Builds/installs fine. macro usage good, consistent. License: GPLv2+ OK (though you probably don't need to %doc COPYING.LGPL, unless I'm missing something) no scriptlets. source verified, $ md5sum *.gz d5aee115ad0d2f3586c359b1dac1d072 compizconfig-backend-kconfig4-0.8.4.tar.gz Consider the items in initial comments as SHOULD items, but not review blockers. APPROVED
Thank you for review . New Package CVS Request ======================= Package Name: compizconfig-backend-kconfig4 Short Description: Kconfig4 backend for libcompizconfig Owners: leigh123linux Branches: F-12 InitialCC: leigh123linux
CVS done (by process-cvs-requests.py).
ping, was this ever imported, can we close this?
(In reply to comment #5) > ping, was this ever imported, can we close this? Yes it was.
Package Change Request ====================== Package Name: compizconfig-backend-kconfig4 New Branches: el6 Owners: leigh123linux
Git done (by process-git-requests).