Bug 556549

I'd greatly prefer if upstream condones or sanctions (or preferably commits) the patch for 0.12.x.

As this only affects the cairo backend, I'll leave the call up to my fellow maintainers to make a decision here.  (Preferably sooner rather than later, since we have poppler-0.12.3 in updates-testing already, we could roll this in too prior to getting pushed to stable updates).

Well.. it seems the really correct way to fix it is to add it the correct functionality to pixman, and then use the pixman API in poppler. This work is going on upstream in pixman, and IIUC, poppler 0.14 will make use of that in the future. 

There's a "band aid" patch which fixes the problem by patching poppler in the meantime in that freedesktop bugzilla for 0.12, but I suspect upstream won't bother applying it. I know "upstream" is the Fedora mantra, but in this case it'd be a stop-gap patch which fixes a very real problem in the current release.

You mean this one?
http://bugs.freedesktop.org/show_bug.cgi?id=5589#c46

I suppose we can try it out (mandriva seems to be).

(In reply to comment #3)
> You mean this one?
> http://bugs.freedesktop.org/show_bug.cgi?id=5589#c46
> 
> I suppose we can try it out (mandriva seems to be).    

Yes, that's the badger.

OK, try it out:
http://koji.fedoraproject.org/koji/buildinfo?buildID=151931

Yep, that's a real improvement - with this evince renders comparatively to xpdf. I'll attach before and after screengrabs.

Created attachment 385504 [details]
Evince and xpdf rendering the same file with (old) poppler 0.12.2

Created attachment 385505 [details]
Evince and xpdf rendering the same file with Evince using poppler 0.12.3-5

poppler-data-0.4.0-1.fc12, poppler-0.12.3-5.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update poppler-data poppler'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0477

Looks like upstream has another proposed patch to implement this,
http://bugs.freedesktop.org/show_bug.cgi?id=5589#c62
should we try that one out instead ?

If we want to consider that, we should probably have pdf sample to test against.

Jonathan, do you have an opinion on either of these?

Am happy to test with the new patch - will do a mock build later unless you beat me to it and push a scratch build to koji.

Am going to attach a sample pdf and screenshots below.

Created attachment 385936 [details]
Evince with poppler 0.12.2 and xpdf rendering the same file

Created attachment 385937 [details]
Evince with poppler 0.12.3-5 and xpdf rendering the same file

Created attachment 385938 [details]
Sample pdf file containing an image

poppler-data-0.4.0-1.fc12, poppler-0.12.3-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update poppler-data poppler'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0477

poppler-data-0.4.0-1.fc12, poppler-0.12.3-7.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update poppler-data poppler'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0477

poppler-data-0.4.0-1.fc12, poppler-0.12.3-8.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.