Bug 556549 - RFE: please add patch to scale images correctly
Summary: RFE: please add patch to scale images correctly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: poppler
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Marek Kašík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-18 17:26 UTC by Jonathan Underwood
Modified: 2010-02-09 05:05 UTC (History)
5 users (show)

Fixed In Version: 0.4.0-1.fc12
Clone Of:
Environment:
Last Closed: 2010-02-09 05:05:33 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Evince and xpdf rendering the same file with (old) poppler 0.12.2 (387.63 KB, image/png)
2010-01-19 21:08 UTC, Jonathan Underwood
no flags Details
Evince and xpdf rendering the same file with Evince using poppler 0.12.3-5 (659.98 KB, image/png)
2010-01-19 21:09 UTC, Jonathan Underwood
no flags Details
Evince with poppler 0.12.2 and xpdf rendering the same file (252.03 KB, image/png)
2010-01-21 14:55 UTC, Jonathan Underwood
no flags Details
Evince with poppler 0.12.3-5 and xpdf rendering the same file (295.75 KB, image/png)
2010-01-21 14:55 UTC, Jonathan Underwood
no flags Details
Sample pdf file containing an image (129.92 KB, application/pdf)
2010-01-21 14:57 UTC, Jonathan Underwood
no flags Details


Links
System ID Private Priority Status Summary Last Updated
FreeDesktop.org 5589 0 None None None Never
Launchpad 248355 0 None None None Never

Description Jonathan Underwood 2010-01-18 17:26:33 UTC
Description of problem:
There's a long standing problem with evince displaying (scaled) images in PDF files which causes them to be horribly pixilated and difficult to read. This is discussed here:

https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/248355
http://bugs.freedesktop.org/show_bug.cgi?id=5589

The freedesktop bug contains a patch to fix it (headed for 0.14) - is there any chance of adding this to the poppler (0.12.x) package on F-12 to improve matters?


TIA.

Comment 1 Rex Dieter 2010-01-18 18:35:07 UTC
I'd greatly prefer if upstream condones or sanctions (or preferably commits) the patch for 0.12.x.

As this only affects the cairo backend, I'll leave the call up to my fellow maintainers to make a decision here.  (Preferably sooner rather than later, since we have poppler-0.12.3 in updates-testing already, we could roll this in too prior to getting pushed to stable updates).

Comment 2 Jonathan Underwood 2010-01-18 18:44:55 UTC
Well.. it seems the really correct way to fix it is to add it the correct functionality to pixman, and then use the pixman API in poppler. This work is going on upstream in pixman, and IIUC, poppler 0.14 will make use of that in the future. 

There's a "band aid" patch which fixes the problem by patching poppler in the meantime in that freedesktop bugzilla for 0.12, but I suspect upstream won't bother applying it. I know "upstream" is the Fedora mantra, but in this case it'd be a stop-gap patch which fixes a very real problem in the current release.

Comment 3 Rex Dieter 2010-01-19 18:02:15 UTC
You mean this one?
http://bugs.freedesktop.org/show_bug.cgi?id=5589#c46

I suppose we can try it out (mandriva seems to be).

Comment 4 Jonathan Underwood 2010-01-19 20:14:51 UTC
(In reply to comment #3)
> You mean this one?
> http://bugs.freedesktop.org/show_bug.cgi?id=5589#c46
> 
> I suppose we can try it out (mandriva seems to be).    

Yes, that's the badger.

Comment 5 Rex Dieter 2010-01-19 20:27:07 UTC
OK, try it out:
http://koji.fedoraproject.org/koji/buildinfo?buildID=151931

Comment 6 Jonathan Underwood 2010-01-19 21:07:20 UTC
Yep, that's a real improvement - with this evince renders comparatively to xpdf. I'll attach before and after screengrabs.

Comment 7 Jonathan Underwood 2010-01-19 21:08:20 UTC
Created attachment 385504 [details]
Evince and xpdf rendering the same file with (old) poppler 0.12.2

Comment 8 Jonathan Underwood 2010-01-19 21:09:10 UTC
Created attachment 385505 [details]
Evince and xpdf rendering the same file with Evince using poppler 0.12.3-5

Comment 9 Fedora Update System 2010-01-21 00:11:45 UTC
poppler-data-0.4.0-1.fc12, poppler-0.12.3-5.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update poppler-data poppler'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0477

Comment 10 Rex Dieter 2010-01-21 13:28:23 UTC
Looks like upstream has another proposed patch to implement this,
http://bugs.freedesktop.org/show_bug.cgi?id=5589#c62
should we try that one out instead ?

If we want to consider that, we should probably have pdf sample to test against.

Jonathan, do you have an opinion on either of these?

Comment 11 Jonathan Underwood 2010-01-21 14:54:15 UTC
Am happy to test with the new patch - will do a mock build later unless you beat me to it and push a scratch build to koji.

Am going to attach a sample pdf and screenshots below.

Comment 12 Jonathan Underwood 2010-01-21 14:55:06 UTC
Created attachment 385936 [details]
Evince with poppler 0.12.2 and xpdf rendering the same file

Comment 13 Jonathan Underwood 2010-01-21 14:55:46 UTC
Created attachment 385937 [details]
Evince with poppler 0.12.3-5 and xpdf rendering the same file

Comment 14 Jonathan Underwood 2010-01-21 14:57:35 UTC
Created attachment 385938 [details]
Sample pdf file containing an image

Comment 15 Fedora Update System 2010-01-22 22:32:50 UTC
poppler-data-0.4.0-1.fc12, poppler-0.12.3-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update poppler-data poppler'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0477

Comment 16 Fedora Update System 2010-01-26 00:59:21 UTC
poppler-data-0.4.0-1.fc12, poppler-0.12.3-7.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update poppler-data poppler'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0477

Comment 17 Fedora Update System 2010-02-09 05:05:12 UTC
poppler-data-0.4.0-1.fc12, poppler-0.12.3-8.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.