Bug 556553
| Summary: | Review Request: apache-resource-bundles - Apache JAR Resource Bundle | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
| Component: | Package Review | Assignee: | Alexander Kurtakov <akurtako> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | akurtako, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | akurtako:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | apache-resource-bundles-2-3.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-16 00:36:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 556556 | ||
|
Description
Mary Ellen Foster
2010-01-18 17:42:47 UTC
Two minor modifications: - Add maven plugin dependencies from POM file - Fix description http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles.spec http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles-2-2.fc12.src.rpm One more change -- the "maven-resource" plugin isn't available on Fedora, so I patched it out. Spec and SRPM at the same place. I'm taking this one. Review:
FIXIT: rpmlint must be run on every package. Output:
apache-resource-bundles.noarch: W: invalid-license ASL
License should be ASL 2.0
apache-resource-bundles.noarch: W: no-documentation
License.txt is shipped in all the sources jars and should be installed as %doc.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
FIXIT: The License field in the package spec file must match the actual license. It should be ASL 2.0
FIXIT: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. Plese install LICENSE.txt as %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's %files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
Please take care for the FIXIT and it is approved.
Modified version is here: http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles.spec http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles-2-3.fc12.src.rpm Thanks, This package is APPROVED. New Package CVS Request ======================= Package Name: apache-resource-bundles Short Description: Apache JAR resource bundle Owners: mef Branches: F-12 F-11 Sorry, wrong flag :( CVS done (by process-cvs-requests.py). apache-resource-bundles-2-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/apache-resource-bundles-2-3.fc12 apache-resource-bundles-2-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update apache-resource-bundles'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1392 apache-resource-bundles-2-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |