Bug 556553 - Review Request: apache-resource-bundles - Apache JAR Resource Bundle
Summary: Review Request: apache-resource-bundles - Apache JAR Resource Bundle
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 556556
TreeView+ depends on / blocked
 
Reported: 2010-01-18 17:42 UTC by Mary Ellen Foster
Modified: 2010-03-16 00:36 UTC (History)
3 users (show)

Fixed In Version: apache-resource-bundles-2-3.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-16 00:36:05 UTC
Type: ---
Embargoed:
akurtako: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mary Ellen Foster 2010-01-18 17:42:47 UTC
Spec URL: http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles.spec
SRPM URL: http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles-2-1.fc12.src.rpm

Description: An archive which contains templates for generating the necessary license files and notices for all Apache releases.

The jar files in this package are necessary for building recent Apache releases (geronimo, etc.) with Maven making use of the remote-resources plugin.

Comment 1 Mary Ellen Foster 2010-01-19 10:19:56 UTC
Two minor modifications:
- Add maven plugin dependencies from POM file
- Fix description

http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles.spec
http://www.macs.hw.ac.uk/~mef3/geronimo/apache-resource-bundles-2-2.fc12.src.rpm

Comment 2 Mary Ellen Foster 2010-01-19 10:32:59 UTC
One more change -- the "maven-resource" plugin isn't available on Fedora, so I patched it out. Spec and SRPM at the same place.

Comment 3 Alexander Kurtakov 2010-01-27 14:29:16 UTC
I'm taking this one.

Comment 4 Alexander Kurtakov 2010-01-29 12:52:26 UTC
Review:

FIXIT: rpmlint must be run on every package. Output:

apache-resource-bundles.noarch: W: invalid-license ASL
License should be ASL 2.0
apache-resource-bundles.noarch: W: no-documentation
License.txt is shipped in all the sources jars and should be installed as %doc.


OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
FIXIT: The License field in the package spec file must match the actual license. It should be ASL 2.0
FIXIT: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. Plese install LICENSE.txt as %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. 
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8. 

Please take care for the FIXIT and it is approved.

Comment 6 Alexander Kurtakov 2010-02-01 13:35:07 UTC
Thanks,
This package is APPROVED.

Comment 7 Mary Ellen Foster 2010-02-01 14:11:02 UTC
New Package CVS Request
=======================
Package Name: apache-resource-bundles
Short Description: Apache JAR resource bundle
Owners: mef
Branches: F-12 F-11

Comment 8 Mary Ellen Foster 2010-02-01 14:19:02 UTC
Sorry, wrong flag :(

Comment 9 Kevin Fenzi 2010-02-01 22:54:26 UTC
CVS done (by process-cvs-requests.py).

Comment 10 Fedora Update System 2010-02-02 10:40:09 UTC
apache-resource-bundles-2-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/apache-resource-bundles-2-3.fc12

Comment 11 Fedora Update System 2010-02-02 20:42:11 UTC
apache-resource-bundles-2-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update apache-resource-bundles'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1392

Comment 12 Fedora Update System 2010-03-16 00:35:59 UTC
apache-resource-bundles-2-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.