Bug 556556
| Summary: | Review Request: geronimo-parent-poms - Parent POM files for geronimo-specs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
| Component: | Package Review | Assignee: | Alexander Kurtakov <akurtako> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | akurtako, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | akurtako:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-23 11:46:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 556553 | ||
| Bug Blocks: | 556780 | ||
|
Description
Mary Ellen Foster
2010-01-18 17:44:28 UTC
A few modifications: - Don't include the apache root pom; it's already in maven2-common-poms - Double check the dependencies to include only what's in the POMs - Add initial Provides for the genesis stuff - Fix changelog http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-parent-poms.spec http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-parent-poms-1.6-2.fc12.src.rpm One more change -- the "maven-resource" plugin isn't available on Fedora, so I patched it out. Spec and SRPM at the same place. Sorry, I'm stupid -- I meant "maven-release" (here and in the other bug) I'm taking this one. Review:
OK: rpmlint must be run on every package. Output:
geronimo-parent-poms.noarch: E: devel-dependency maven2-plugin-source False positive, ignore it.
geronimo-parent-poms.noarch: W: no-documentation Nothing suitable, ignore it.
SPECS/geronimo-parent-poms.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 26, tab: line 3)
Not a blocker but will be nice to fix it.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
OK: All build dependencies must be listed in BuildRequires
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's %files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK: All filenames in rpm packages must be valid UTF-8.
Please remove %config(noreplace) from the _mavendepmapfragdir line in %files. I know that this creates an rpmlint warning but depmap files are supposed to be replaced everytime a package is installed/updated
Fixed: http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-parent-poms.spec http://www.macs.hw.ac.uk/~mef3/geronimo/geronimo-parent-poms-1.6-3.fc12.src.rpm Thanks, This package is APPROVED. New Package CVS Request ======================= Package Name: geronimo-parent-poms Short Description: Parent POM files for geronimo-specs Owners: mef Branches: F-12 CVS done (by process-cvs-requests.py). Can we close the bug and all the other geronimo bugs now that it's in rawhide? I assume that you will not push this to F-12. Good point -- closing them now. |