Bug 557794
| Summary: | Review Request: ykpers - Yubikey personalization tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Maxim Burgerhout <maxim> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mads, maurizio.antillon, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2-4.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-02 17:08:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 557776 | ||
| Bug Blocks: | |||
|
Description
Maxim Burgerhout
2010-01-22 15:56:55 UTC
Some notes:
* SourceURL
- It is recommended to use %{name}, %{version} (especially
%{version}) in source URL because with this you won't probably
have to modify sourceURL when version is upgraded.
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D
* pkgconfig
- "Requires: pkgconfig" on -devel subpackage is no longer needed
(on Fedora) because current rpmbuild will automatically add this
dependency when pkgconfig .pc file is found.
* Timestamps
- Like bug 557776, please consider to add 'INSTALL="install -p'
to "make install".
* Documents
- "INSTALL" file is usually for people trying to build the software
by themselves and is not needed for people trying to install it
using rpm.
* Directory ownership issue
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
- The directory "%{_includedir}/ykpers-1/" itself is not owned
by any packages.
Thanks again for looking into another package, Mamoru! I really appreciate this! I had fixed your notes for bug 557776 for this one already, mostly. I just hadn't put up the files yet. Sorry for that. Here goes: - SourceURL: macros in Source0 now - pkgconfig: removed it from Requires - Timestamps: added INSTALL="%{__install} -p" - Documents: INSTALL removed from %doc - Ownership: replaced tree with %{_includedir}/ykpers-1/ in %files New files at: - http://dl.dropbox.com/u/284093/update-2/ykpers.spec - http://dl.dropbox.com/u/284093/update-2/ykpers-1.2-3.fc12.src.rpm Oops. Bit too fast there. Took the RPM_OPT_FLAGS out of this one too. http://dl.dropbox.com/u/284093/update-3/ykpers.spec http://dl.dropbox.com/u/284093/update-3/ykpers-1.2-4.fc12.src.rpm Okay.
Note:
- From next version, you can reset the "release" number (in the
spec file) to 1%{?dist} when version is upgraded.
----------------------------------------------------
This package (ykpers) is APPROVED by mtasaka
----------------------------------------------------
Again, thank you. Here's the CVS request: New Package CVS Request ======================= Package Name: ykpers Short Description: Yubico's YubiKey can be re-programmed with a new AES key. This is a library that makes this an easy task. Owners: wzzrd Branches: F-12 InitialCC: CVS done (by process-cvs-requests.py). ykpers-1.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ykpers-1.2-4.fc12 Had to wait for libyubikey (#557776) to hit stable before I could build ykpers and submit it to Bodhi as a newpackage update for F12, but it's in there now! Closing. ykpers-1.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: ykpers New Branches: el5 el6 Owners: wzzrd Recent builds of fedora-packager require ykpers (and therefore libyubikey); fedora-packager availability in EPEL requires availability of ykpers and libyubikey in EPEL, too. Git done (by process-git-requests). |