Bug 557794 - Review Request: ykpers - Yubikey personalization tool
Summary: Review Request: ykpers - Yubikey personalization tool
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
Depends On: 557776
TreeView+ depends on / blocked
Reported: 2010-01-22 15:56 UTC by Maxim Burgerhout
Modified: 2013-01-13 11:27 UTC (History)
4 users (show)

Fixed In Version: 1.2-4.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-02-02 17:08:57 UTC
Type: ---
mtasaka: fedora-review+
tcallawa: fedora-cvs+

Attachments (Terms of Use)

Description Maxim Burgerhout 2010-01-22 15:56:55 UTC
Spec URL: http://dl.dropbox.com/u/284093/ykpers.spec
SRPM URL: http://dl.dropbox.com/u/284093/ykpers-1.1-1.fc12.src.rpm
Description: Program to re-programm a YubiKey with a new AES key

ykpers is a simple tool to write a new, custom AES key to the Yubikey. It depends on libyubikey (#557776).

This package and libyubikey are my first packages for Fedora, so I will need a sponsor. I'm happy to answer any questions.

Comment 1 Mamoru TASAKA 2010-01-25 18:02:36 UTC
Some notes:

* SourceURL
  - It is recommended to use %{name}, %{version} (especially
    %{version}) in source URL because with this you won't probably
    have to modify sourceURL when version is upgraded.

* pkgconfig
  - "Requires: pkgconfig" on -devel subpackage is no longer needed
    (on Fedora) because current rpmbuild will automatically add this
    dependency when pkgconfig .pc file is found.

* Timestamps
  - Like bug 557776, please consider to add 'INSTALL="install -p'
    to "make install".

* Documents
  - "INSTALL" file is usually for people trying to build the software
    by themselves and is not needed for people trying to install it
    using rpm.

* Directory ownership issue
  - The directory "%{_includedir}/ykpers-1/" itself is not owned
    by any packages.

Comment 2 Maxim Burgerhout 2010-01-25 19:23:25 UTC
Thanks again for looking into another package, Mamoru! I really appreciate this!

I had fixed your notes for bug 557776 for this one already, mostly. I just hadn't put up the files yet. Sorry for that. Here goes:

- SourceURL: macros in Source0 now
- pkgconfig: removed it from Requires
- Timestamps: added INSTALL="%{__install} -p"
- Documents: INSTALL removed from %doc
- Ownership: replaced tree with %{_includedir}/ykpers-1/ in %files

New files at:

- http://dl.dropbox.com/u/284093/update-2/ykpers.spec
- http://dl.dropbox.com/u/284093/update-2/ykpers-1.2-3.fc12.src.rpm

Comment 3 Maxim Burgerhout 2010-01-25 20:18:50 UTC
Oops. Bit too fast there. Took the RPM_OPT_FLAGS out of this one too.


Comment 4 Mamoru TASAKA 2010-01-26 16:40:30 UTC

- From next version, you can reset the "release" number (in the
  spec file) to 1%{?dist} when version is upgraded.

  This package (ykpers) is APPROVED by mtasaka

Comment 5 Maxim Burgerhout 2010-01-27 19:52:08 UTC
Again, thank you. Here's the CVS request:

New Package CVS Request
Package Name: ykpers
Short Description: Yubico's YubiKey can be re-programmed with a new AES key. This is a library that makes this an easy task.
Owners: wzzrd
Branches: F-12

Comment 6 Jason Tibbitts 2010-01-27 21:53:52 UTC
CVS done (by process-cvs-requests.py).

Comment 7 Fedora Update System 2010-02-01 19:13:22 UTC
ykpers-1.2-4.fc12 has been submitted as an update for Fedora 12.

Comment 8 Maxim Burgerhout 2010-02-01 19:18:31 UTC
Had to wait for libyubikey (#557776) to hit stable before I could build ykpers and submit it to Bodhi as a newpackage update for F12, but it's in there now!

Comment 9 Mamoru TASAKA 2010-02-02 17:08:57 UTC

Comment 10 Fedora Update System 2010-02-02 20:44:33 UTC
ykpers-1.2-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Maxim Burgerhout 2010-10-13 06:51:25 UTC
Package Change Request
Package Name: ykpers
New Branches: el5 el6
Owners: wzzrd

Recent builds of fedora-packager require ykpers (and therefore libyubikey); fedora-packager availability in EPEL requires availability of ykpers and libyubikey in EPEL, too.

Comment 12 Tom "spot" Callaway 2010-10-13 15:10:08 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.