Bug 558875
| Summary: | no valid sudoers sources found | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Arthur Clement <clement.arthur> | ||||
| Component: | sudo | Assignee: | Daniel Kopeček <dkopecek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | rawhide | CC: | awilliam, dkopecek, kzak, ville.skytta | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-04-23 19:45:41 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 507681 | ||||||
| Attachments: |
|
||||||
|
Description
Arthur Clement
2010-01-26 16:22:51 UTC
This appears to be because of the newly added #includedir directive. It looks like sudo barfs if the included dir is empty which I failed to test when suggesting adding this feature, sorry about that. IMO this sounds like a upstream bug; I don't think an empty included dir should be a problem. Apart from getting a real fix for that, one way to work around it would be to add let's say a /etc/sudoers.d/README containing valid sudoers format comments, something like the attached patch (README is intentionally a non-%config file even though rpmlint complains about it). Created attachment 394420 [details]
Add placeholder README to /etc/sudoers.d
From the ChangeLog:
Major changes between version 1.7.2p1 and 1.7.2p2:
...
* No longer produce a parse error when #includedir references a directory that contains no valid filenames.
...
Seems to be a regression. I'm going to investigate this and hopefully do a new build tomorrow.
Ok, it's not a regression... the fix didn't made it to the release tarball (don't know why). Here are the cvs commits: toke.c: http://www.sudo.ws/cgi-bin/cvsweb/sudo/toke.c.diff?r1=1.37&r2=1.38&f=h toke.l: http://www.sudo.ws/cgi-bin/cvsweb/sudo/toke.l.diff?r1=1.38&r2=1.39&f=h the toke.l part is present in the 1.7.2p2 tarball but the toke.c part is not. So I guest it's a mistake. Reported upstream and a new build for rawhide is on the way. Discussed at today's blocker review meeting. Two of us confirmed that current F13 sudo, sudo-1.7.2p6-1.fc13.x86_64 , seems to behave fine. We're closing this; please re-open if we're missing something. Thanks! -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers |