Bug 559828
| Summary: | Crash when saving picture with empty description on FLAC file | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Cronenworth <mike> | ||||||
| Component: | easytag | Assignee: | Matthias Saou <matthias> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 12 | CC: | bugzilla, matthias, musmeh55, zayzayats | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | easytag-2.1.6-5.fc11 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2010-05-12 17:52:56 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Michael Cronenworth
2010-01-29 05:32:44 UTC
Created attachment 387500 [details]
easytag seg fault backtrace
Created attachment 397237 [details]
One liner fix
Here's the one liner fix for the problem. The author set the picture description pointer to NULL and attempted to pass this to the FLAC lib function, which is incorrect. The patch will strdup() an empty string, which will be treated the same as if there was a description buffer. I successfully wrote new metadata to a FLAC file with the attached patch and metaflac successfully parsed and displayed the new metadata without error.
As it's been two years since upstream has released a version, and upstream has not responded to my e-mail about this bug, what are the chances that this patch will make it anywhere beyond this bug report?
*** Bug 578646 has been marked as a duplicate of this bug. *** *** Bug 563283 has been marked as a duplicate of this bug. *** *** Bug 562609 has been marked as a duplicate of this bug. *** I'll include this fix (and at least one other) in the next update of the package. Sorry for the delay in getting this done... *** Bug 544533 has been marked as a duplicate of this bug. *** easytag-2.1.6-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/easytag-2.1.6-5.fc12 easytag-2.1.6-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/easytag-2.1.6-5.fc13 easytag-2.1.6-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/easytag-2.1.6-5.fc11 easytag-2.1.6-5.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update easytag'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/easytag-2.1.6-5.fc13 easytag-2.1.6-5.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update easytag'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/easytag-2.1.6-5.fc12 easytag-2.1.6-5.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update easytag'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/easytag-2.1.6-5.fc11 easytag-2.1.6-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. easytag-2.1.6-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. easytag-2.1.6-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |