Bug 560169
| Summary: | Review Request: bytelist - A java library for lists of bytes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Victor G. Vasilyev <victor.vasilyev> |
| Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mmorsi, notting |
| Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-11 20:10:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 560170 | ||
| Bug Blocks: | 541638, 560172, 561484 | ||
|
Description
Victor G. Vasilyev
2010-01-30 02:17:59 UTC
*** Bug 561473 has been marked as a duplicate of this bug. *** Looks good for most part, builds find in mock and passes most review guidelines.
A couple of specifics though:
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
Also I was able to compile the bytelist rpm w/ the java-gcj features. See the guidelines / my bytelist spec for how to do so:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
http://mo.morsi.org/files/jruby/bytelist.spec
As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010".
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/bytelist/F-11/bytelist.spec?view=markup
(In reply to comment #2) > The following line doesn't work as intended: > find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; > > You can replace it w/ this: > find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \; > fixed according to the Specfile Template for ant https://fedoraproject.org/wiki/Packaging:Java#ant_2 > > Also I was able to compile the bytelist rpm w/ the java-gcj features. See the > guidelines / my bytelist spec for how to do so: > > http://fedoraproject.org/wiki/Packaging/GCJGuidelines > http://mo.morsi.org/files/jruby/bytelist.spec > Clarification why the gcj bits was removed is here: https://bugzilla.redhat.com/show_bug.cgi?id=560170#c5 Also, please note, the Specfile Template for ant doesn't contain gcj bits. > > As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". > fixed. > Also why did you remove the previous entries from the changelog > http://cvs.fedoraproject.org/viewvc/rpms/bytelist/F-11/bytelist.spec?view=markup fixed. The second release is prepared for review: Spec URL: http://victorv.fedorapeople.org/files/bytelist.spec SRPM URL: http://victorv.fedorapeople.org/files/bytelist-1.0.3-2.fc13.src.rpm > The second release is prepared for review: > Spec URL: http://victorv.fedorapeople.org/files/bytelist.spec > SRPM URL: http://victorv.fedorapeople.org/files/bytelist-1.0.3-2.fc13.src.rpm Everything looks good. Package is fully compliant w/ guidelines and builds fine in mock when jcodings is installed. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. Package Change Request ====================== Package Name: bytelist New Branches: Owners: mmorsi victorv Updated Description: A java library for lists of bytes The package https://admin.fedoraproject.org/pkgdb/packages/name/bytelist exists, but has been orphaned and deprecated. cvs done. Note that you will need to file a bug in the rel-eng track asking for this package to be unblocked now before it will build in rawhide. cvs import done. https://fedorahosted.org/rel-eng/ticket/3377 |