Bug 563000
| Summary: | Review Request: rubygem-compass - A Sass-based CSS Meta-Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mo Morsi <mmorsi> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jguiditt, mfojtik, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-03 17:28:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 562998 | ||
| Bug Blocks: | |||
|
Description
Mo Morsi
2010-02-09 00:16:17 UTC
File listed twice: /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/LICENSE.markdown /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/README.markdown ---- Tests are not executed (./tests) ---- Do not use %define, use %global ---- ./docs are not installed (not listed in %files) Spec updated based on feedback and new version uploaded: Spec URL: http://mo.morsi.org/files/gems/rubygem-compass.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-compass-0.8.17-2.fc11.src.rpm rpmlint rpmbuild/RPMS/noarch/rubygem-compass-0.8.17-1.fc11.noarch.rpm rpmbuild/SRPMS/rubygem-compass-0.8.17-1.fc11.src.rpm rpmbuild/SPECS/rubygem-compass.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. (In reply to comment #1) > File listed twice: > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/LICENSE.markdown > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/README.markdown These two files are different (LICENSE, README) and rpmlint isn't complaining about any duplicate files. Can you elaborate if this is still an issue? > ---- > Tests are not executed (./tests) Fixed. > ---- > Do not use %define, use %global Fixed. > ---- > ./docs are not installed (not listed in %files) The docs are included as the last entry in %files, %doc %{gemdir}/doc/%{gemname}-%{version} Were you looking for other docs, if so which ones? Also resolved the issue w/ the misspelled macros above. Just comment for this: (In reply to comment #2) > (In reply to comment #1) > > File listed twice: > > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/LICENSE.markdown > > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/README.markdown > > These two files are different (LICENSE, README) and rpmlint isn't complaining > about any duplicate files. Can you elaborate if this is still an issue? Note that %files entry ------------------------------------------------- %files foo/ ------------------------------------------------- contains the directory foo/ itself _and_ all files/directories/etc under the directory foo, and %{gemdir}/gems/%{gemname}-%{version}/ (in %files entry) is the same as %{geminstdir} (by the as you defined %geminstdir, please use this macro in %files), while ------------------------------------------------- %files %dir foo/ ------------------------------------------------- contains the directory foo/ only. (In reply to comment #3) > Just comment for this: > > (In reply to comment #2) > > (In reply to comment #1) > > > File listed twice: > > > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/LICENSE.markdown > > > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/README.markdown > > > > These two files are different (LICENSE, README) and rpmlint isn't complaining > > about any duplicate files. Can you elaborate if this is still an issue? > > Note that %files entry > ------------------------------------------------- > %files > foo/ > ------------------------------------------------- > contains the directory foo/ itself _and_ all files/directories/etc > under the directory foo, and %{gemdir}/gems/%{gemname}-%{version}/ > (in %files entry) is the same as %{geminstdir} > (by the as you defined %geminstdir, please use this macro in %files), > while > ------------------------------------------------- > %files > %dir foo/ > ------------------------------------------------- > contains the directory foo/ only. Fixed. Spec updated based on feedback and new version uploaded: Spec URL: http://mo.morsi.org/files/gems/rubygem-compass.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-compass-0.8.17-3.fc11.src.rpm rpmlint rpmbuild/SPECS/rubygem-compass.spec rpmbuild/SRPMS/rubygem-compass-0.8.17-3.fc11.src.rpm rpmbuild/RPMS/noarch/rubygem-compass-0.8.17-3.fc11.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2115523 # MUST: rpmlint must be run on every package. The output should be posted in
the review.
No warning/errors.
# MUST: The package must be named according to the Package Naming Guidelines .
OK
# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
MIT
# MUST: The spec file must be written in American English.
OK
# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
OK
# MUST: Header files must be in a -devel package.
No headers.
# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK
# MUST: All filenames in rpm packages must be valid UTF-8.
OK
New Package CVS Request ======================= Package Name: rubygem-compass Short Description: A Sass-based CSS Meta-Framework Owners: mmorsi Branches: F-11 F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). Please remember to assign the review to the reviewer. Since this package is already pushed into distrubution, closing. |